Bug 74497 – [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kentaro Hara]

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog.

Global variables in prepare-ChangeLog can be categorized as follows:

[A: Constant variables]
$changeLogTimeZone
$SVN
$GIT
%supportedTestExtensions

[B: Arguments]
$bugDescription
$bugNumber
$name
$emailAddress
$mergeBase
$gitCommit
$gitIndex
$gitReviewer
$openChangeLogs
$writeChangeLogs
$showHelp
$spewDiff
$updateChangeLogs
$parseOptionsResult

[C: Global variables that are used many times here and there]
$isSVN
$isGit

[D: Global variables that are used only a few times]
%paths
$changedFiles
$conflictFiles
$functionLists
$addedRegressionTests
$bugURL
$filesInChangeLog
$prefixes
$changeLogs

In this bug, we remove several global variables in [B]. Accurately, we make $bugDescription, $bugNumber, $name, $emailAddress, $gitReviewer and $writeChangeLogs be used only through parameter passing.

I'll remove all global variables completely in the next bug.

[Kentaro Hara]

Created attachment 119200 [details]
Patch

[Kentaro Hara]

Created attachment 119412 [details]
rebased patch

[WebKit Review Bot]

Comment on attachment 119412 [details]
rebased patch

Clearing flags on attachment: 119412

Committed r102988: <http://trac.webkit.org/changeset/102988>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.