Bug 74491 – Upstream FileSystemBlackBerry.cpp into WebCore/platform/blackberry

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Mary Wu]

This file upstream was split from bug #73798 per request of Nikolas Zimmermann.

[Mary Wu]

Created attachment 119179 [details]
Patch

[Leo Yang]

Why couldn't we share listDirectory with posix? Isn't posix more suitable for the BlackBerry port than efl in this case?

[Mary Wu]

yes, thanks for pointing out...update soon

[Mary Wu]

Created attachment 119363 [details]
Patch

[Leo Yang]

Comment on attachment 119363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119363&action=review

Informal review.

> Source/WebCore/ChangeLog:8
> +        We get most of FileSystem implementations from posix porting.        

How about changing this line to "Because we are using most of file system implementations from the POSIX porting we only need to implement the left functions." ?
I would add an empty line after this line.

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:39
> +bool unloadModule(PlatformModule)
> +{
> +    return false;

Don't we use this API? Why not implement?

> Source/WebCore/platform/blackberry/FileSystemBlackBerry.cpp:44
> +    return "";

Couldn't we implement this on the BlackBerry/QNX platform?

[Mary Wu]

Thanks for comments, Leo. Both interfaces are only used in plugin which seems our plugin porting don't really use them. Maybe in future we need to implement.

[Mary Wu]

(In reply to comment #6)
> Thanks for comments, Leo. Both interfaces are only used in plugin which seems our plugin porting don't really use them. Maybe in future we need to implement.

use/call them

[Mary Wu]

commit log update...

[Mary Wu]

Created attachment 119379 [details]
Patch

[Rob Buis]

Comment on attachment 119379 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 119379 [details]
Patch

Clearing flags on attachment: 119379

Committed r103016: <http://trac.webkit.org/changeset/103016>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.