Bug 74444 - [Blackberry] Fix a leak in BackingStore class
Summary: [Blackberry] Fix a leak in BackingStore class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: arvid2.nilsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 13:32 PST by arvid2.nilsson
Modified: 2011-12-13 15:40 PST (History)
3 users (show)

See Also:


Attachments
Patch (585 bytes, patch)
2011-12-13 13:42 PST, arvid2.nilsson
no flags Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2011-12-13 14:17 PST, arvid2.nilsson
no flags Details | Formatted Diff | Diff
Patch (1.27 KB, patch)
2011-12-13 14:22 PST, arvid2.nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description arvid2.nilsson 2011-12-13 13:32:21 PST
Don't leak the blit generation mutex+cond var
Comment 1 arvid2.nilsson 2011-12-13 13:42:49 PST
Created attachment 119078 [details]
Patch
Comment 2 arvid2.nilsson 2011-12-13 14:15:58 PST
Comment on attachment 119078 [details]
Patch

There's no ChangeLog entry
Comment 3 arvid2.nilsson 2011-12-13 14:17:32 PST
Created attachment 119082 [details]
Patch
Comment 4 Antonio Gomes 2011-12-13 14:19:15 PST
Comment on attachment 119082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119082&action=review

> Source/WebKit/ChangeLog:7
> +2011-12-13  Arvid Nilsson  <anilsson@rim.com>
> +
> +        [Blackberry] Fix a leak in BackingStore class
> +        https://bugs.webkit.org/show_bug.cgi?id=74444
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Arvid, could you add to the changelog what was leaking?
Comment 5 arvid2.nilsson 2011-12-13 14:22:46 PST
Created attachment 119083 [details]
Patch
Comment 6 Antonio Gomes 2011-12-13 14:25:29 PST
Comment on attachment 119083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119083&action=review

> Source/WebKit/ChangeLog:9
> +        Don't leak the blit generation condvar and mutex.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=74444
> +
> +        Reviewed by NOBODY (OOPS!).

The order is bug title, bug url, reviewed by, fix explanation :)

ok for now though.
Comment 7 WebKit Review Bot 2011-12-13 15:40:02 PST
Comment on attachment 119083 [details]
Patch

Clearing flags on attachment: 119083

Committed r102713: <http://trac.webkit.org/changeset/102713>
Comment 8 WebKit Review Bot 2011-12-13 15:40:07 PST
All reviewed patches have been landed.  Closing bug.