Bug 74428 – Create reftest for outline-sides-in-region

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ethan Malasky]

This test should be satisfied with a reftest instead of a bitmap test.

[Ethan Malasky]

Created attachment 119073 [details]
add reftest, adjust test case, remove old expected files

[Ethan Malasky]

Created attachment 119080 [details]
reftest, removals, plus test enablement for chromium

[Darin Adler]

Comment on attachment 119080 [details]
reftest, removals, plus test enablement for chromium

View in context: https://bugs.webkit.org/attachment.cgi?id=119080&action=review

> LayoutTests/fast/regions/outline-sides-in-region-expected.html:15
> +	<div id="region">
> +		<div id="source">

I suggest omitting the ids.

> LayoutTests/fast/regions/outline-sides-in-region.html:10
> +	/* There appears to be a bug in margin-top collapsing for the first region.
> +	 That issue will be filed separately. For now, forcing margin-top:0 allows us
> +	to create an accurate reftest for outline drawing. */

Strange indentation here. Also, we normally use // comments rather than /* comments.

[Ethan Malasky]

Thanks, Darin. Applying your suggestions. Will post a cleaner patch.

[Ethan Malasky]

Created attachment 119295 [details]
one more, incorporating cleanup suggestions

Removed ids, and also the whole CSS block comment, since astearns has since verified that the margin-top non-collapsing in the region is intended behavior.

[WebKit Review Bot]

Comment on attachment 119295 [details]
one more, incorporating cleanup suggestions

Clearing flags on attachment: 119295

Committed r102830: <http://trac.webkit.org/changeset/102830>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.