Bug 74384 - [Non-Mac] Change event should be fired when changing option by using keyboard.
Summary: [Non-Mac] Change event should be fired when changing option by using keyboard.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rakesh
URL: http://jsfiddle.net/Cq89G/
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 00:23 PST by yosin
Modified: 2011-12-14 05:00 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch (5.02 KB, patch)
2011-12-14 00:11 PST, Rakesh 		no flags Details | Formatted Diff | Diff
Proposed patch (6.57 KB, patch)
2011-12-14 01:54 PST, Rakesh 		no flags Details | Formatted Diff | Diff
Updated patch (6.63 KB, patch)
2011-12-14 03:19 PST, Rakesh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2011-12-13 00:23:18 PST 
onchange event should be fired when changing option by using keyboard.

This bug is imported from
http://crbug.com/90447
Comment 1 Rakesh 2011-12-14 00:11:32 PST 
Created attachment 119169 [details]
Proposed patch

For the up/down/home/end/pageup/pagedown key events, the DispatchChangeEvent option flag was not set
Comment 2 Kent Tamura 2011-12-14 00:22:22 PST 
Comment on attachment 119169 [details]
Proposed patch

The code looks good.
Would you move the test to fast/forms/select/ please?
Comment 3 Kent Tamura 2011-12-14 00:30:36 PST 
Comment on attachment 119169 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119169&action=review

> LayoutTests/ChangeLog:11
> +        * fast/forms/menulist-onchange-fired-with-key-up-down-expected.txt: Added.
> +        * fast/forms/menulist-onchange-fired-with-key-up-down.html: Added.

The test won't work on Apple Mac and Chromium Mac.  We should add this test to LayoutTests/platform/mac/Skipped and LayoutTests/platform/chromium/test_expectations.txt.
Comment 4 Rakesh 2011-12-14 01:15:21 PST 
(In reply to comment #2)
> (From update of attachment 119169 [details])
> The code looks good.
> Would you move the test to fast/forms/select/ please?

ok, will do that.

> > +        * fast/forms/menulist-onchange-fired-with-key-up-down-expected.txt: Added.
> > +        * fast/forms/menulist-onchange-fired-with-key-up-down.html: Added.
> 
> The test won't work on Apple Mac and Chromium Mac.  We should add this test to LayoutTests/platform/mac/Skipped and LayoutTests/platform/chromium/test_expectations.txt.

ok, will add these too.

Thanks for taking time to review.
Comment 5 Rakesh 2011-12-14 01:54:35 PST 
Created attachment 119178 [details]
Proposed patch

Skipped test for MAC, moved the test to fast/forms/select/
Comment 6 Kent Tamura 2011-12-14 01:56:13 PST 
Comment on attachment 119178 [details]
Proposed patch

Looks good.
Comment 7 WebKit Review Bot 2011-12-14 02:05:14 PST 
Comment on attachment 119178 [details]
Proposed patch

Rejecting attachment 119178 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
-key-up-down.html
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3784.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 498.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10873153
Comment 8 Rakesh 2011-12-14 03:19:39 PST 
Created attachment 119190 [details]
Updated patch

Changes on latest code.
Comment 9 WebKit Review Bot 2011-12-14 05:00:37 PST 
Comment on attachment 119190 [details]
Updated patch

Clearing flags on attachment: 119190

Committed r102767: <http://trac.webkit.org/changeset/102767>
Comment 10 WebKit Review Bot 2011-12-14 05:00:41 PST 
All reviewed patches have been landed.  Closing bug.