Bug 74381 - Upstream 3 files into WebCore/platform/blackberry
Summary: Upstream 3 files into WebCore/platform/blackberry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency tree / graph
 
Reported: 2011-12-12 22:47 PST by Mary Wu
Modified: 2011-12-13 21:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.41 KB, patch)
2011-12-12 23:10 PST, Mary Wu 		no flags Details | Formatted Diff | Diff
Patch (11.37 KB, patch)
2011-12-13 19:02 PST, Mary Wu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2011-12-12 22:47:42 PST 
Upstream 3 files into WebCore/platform/blackberry:
ClipboardBlackBerry.cpp/h, PasteboardBlackBerry.cpp
Comment 1 Mary Wu 2011-12-12 23:10:10 PST 
Created attachment 118958 [details]
Patch
Comment 2 Rob Buis 2011-12-13 13:10:20 PST 
Comment on attachment 118958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118958&action=review

Looks very good, can be cleaned up a bit more I think.

> Source/WebCore/platform/blackberry/ClipboardBlackBerry.cpp:2
> + * Copyright (C) 2010 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:2
> + * Copyright (C) 2009 Research In Motion Limited. All rights reserved.

This was touched in 2011, may as well update that fact.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:91
> +    String html = String::fromUTF8(BlackBerry::Platform::Clipboard::readHTML().c_str());

RefPtr<DocumentFragment> fragment could be declared here.

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:96
> +        if (fragment)

Can write this like if (fragment = createFragmentFromMarkup(frame->document(), html, url, FragmentScriptingNotAllowed))

> Source/WebCore/platform/blackberry/PasteboardBlackBerry.cpp:106
> +    if (fragment) {

Can write this like if (fragment = createFragmentFromText(context.get(), text))
Comment 3 Mary Wu 2011-12-13 19:02:54 PST 
Created attachment 119136 [details]
Patch
Comment 4 Rob Buis 2011-12-13 19:21:58 PST 
Comment on attachment 119136 [details]
Patch

Looks great!
Comment 5 WebKit Review Bot 2011-12-13 21:23:02 PST 
Comment on attachment 119136 [details]
Patch

Clearing flags on attachment: 119136

Committed r102739: <http://trac.webkit.org/changeset/102739>
Comment 6 WebKit Review Bot 2011-12-13 21:23:08 PST 
All reviewed patches have been landed.  Closing bug.