Bug 74375 - [chromium] static initializer in ScrollbarThemeChromiumMac.mm
Summary: [chromium] static initializer in ScrollbarThemeChromiumMac.mm
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61144
Blocks: 74365
  Show dependency tree / graph
 
Reported: 2011-12-12 18:19 PST by Tony Chang
Modified: 2011-12-27 13:49 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-12-12 18:19:53 PST 
/Users/tc/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:155:34: error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
static ScrollbarButtonsPlacement gButtonPlacement = isScrollbarOverlayAPIAvailable() ? ScrollbarButtonsNone : ScrollbarButtonsDoubleEnd;
                                 ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


This global is set in updateArrowPlacement, so it wasn't obvious to me what the right way to fix this is.  Can we just move it into a static function?
Comment 1 Nico Weber 2011-12-13 09:56:18 PST 
Sail has a CL to remove this in bug 61144
Comment 2 Tony Chang 2011-12-27 13:49:10 PST 
Fixed in bug 61144 by http://trac.webkit.org/changeset/103354 .