WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
74375
[chromium] static initializer in ScrollbarThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=74375
Summary
[chromium] static initializer in ScrollbarThemeChromiumMac.mm
Tony Chang
Reported
2011-12-12 18:19:53 PST
/Users/tc/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:155:34: error: declaration requires a global constructor [-Werror,-Wglobal-constructors] static ScrollbarButtonsPlacement gButtonPlacement = isScrollbarOverlayAPIAvailable() ? ScrollbarButtonsNone : ScrollbarButtonsDoubleEnd; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This global is set in updateArrowPlacement, so it wasn't obvious to me what the right way to fix this is. Can we just move it into a static function?
Attachments
Add attachment
proposed patch, testcase, etc.
Nico Weber
Comment 1
2011-12-13 09:56:18 PST
Sail has a CL to remove this in
bug 61144
Tony Chang
Comment 2
2011-12-27 13:49:10 PST
Fixed in
bug 61144
by
http://trac.webkit.org/changeset/103354
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug