RESOLVED FIXED Bug 74360
HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload 
https://bugs.webkit.org/show_bug.cgi?id=74360
Summary HTMLEmbedObject should match HTMLObjectElement by stopping any load when it i...
Eric Seidel (no email)
Reported 2011-12-12 15:26:55 PST
HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
Attachments
Patch (5.97 KB, patch)
2011-12-12 15:31 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.88 KB, patch)
2012-01-25 15:43 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-12 15:31:30 PST
Created attachment 118882 [details] Patch
Eric Seidel (no email)
Comment 2 2011-12-12 15:32:17 PST
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html was added by aestes. CCing him and the reviewer ap in case they'd like to see this go by.
Eric Seidel (no email)
Comment 3 2011-12-12 15:37:41 PST
I suspect we should audit all callers to dispatchBeforeLoadEvent at some point. :)
WebKit Review Bot
Comment 4 2011-12-12 16:43:43 PST
Comment on attachment 118882 [details] Patch Rejecting attachment 118882 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ebCore/html/HTMLEmbedElement.cpp.rej patching file Source/WebCore/html/HTMLObjectElement.cpp Hunk #1 FAILED at 316. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10845102
Eric Seidel (no email)
Comment 5 2012-01-25 14:24:45 PST
This patch depends on bug 74340.
WebKit Review Bot
Comment 6 2012-01-25 15:27:44 PST
Comment on attachment 118882 [details] Patch Rejecting attachment 118882 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ebCore/html/HTMLEmbedElement.cpp.rej patching file Source/WebCore/html/HTMLObjectElement.cpp Hunk #1 FAILED at 316. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/11349065
Eric Seidel (no email)
Comment 7 2012-01-25 15:31:27 PST
Comment on attachment 118882 [details] Patch This should be able to land now. Sorry for the noise.
Eric Seidel (no email)
Comment 8 2012-01-25 15:32:24 PST
Comment on attachment 118882 [details] Patch Actually, nm. Updating.
Eric Seidel (no email)
Comment 9 2012-01-25 15:43:04 PST
Created attachment 124026 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-01-25 16:00:18 PST
Comment on attachment 124026 [details] Patch for landing Clearing flags on attachment: 124026 Committed r105938: <http://trac.webkit.org/changeset/105938>
WebKit Review Bot
Comment 11 2012-01-25 16:00:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.