Bug 74360 - HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
Summary: HTMLEmbedObject should match HTMLObjectElement by stopping any load when it i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 74340
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-12 15:26 PST by Eric Seidel (no email)
Modified: 2012-01-25 16:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.97 KB, patch)
2011-12-12 15:31 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (5.88 KB, patch)
2012-01-25 15:43 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-12-12 15:26:55 PST 
HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
Comment 1 Eric Seidel (no email) 2011-12-12 15:31:30 PST 
Created attachment 118882 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-12-12 15:32:17 PST 
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html was added by aestes.  CCing him and the reviewer ap in case they'd like to see this go by.
Comment 3 Eric Seidel (no email) 2011-12-12 15:37:41 PST 
I suspect we should audit all callers to dispatchBeforeLoadEvent at some point. :)
Comment 4 WebKit Review Bot 2011-12-12 16:43:43 PST 
Comment on attachment 118882 [details]
Patch

Rejecting attachment 118882 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebCore/html/HTMLEmbedElement.cpp.rej
patching file Source/WebCore/html/HTMLObjectElement.cpp
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10845102
Comment 5 Eric Seidel (no email) 2012-01-25 14:24:45 PST 
This patch depends on bug 74340.
Comment 6 WebKit Review Bot 2012-01-25 15:27:44 PST 
Comment on attachment 118882 [details]
Patch

Rejecting attachment 118882 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebCore/html/HTMLEmbedElement.cpp.rej
patching file Source/WebCore/html/HTMLObjectElement.cpp
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/11349065
Comment 7 Eric Seidel (no email) 2012-01-25 15:31:27 PST 
Comment on attachment 118882 [details]
Patch

This should be able to land now.  Sorry for the noise.
Comment 8 Eric Seidel (no email) 2012-01-25 15:32:24 PST 
Comment on attachment 118882 [details]
Patch

Actually, nm.  Updating.
Comment 9 Eric Seidel (no email) 2012-01-25 15:43:04 PST 
Created attachment 124026 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-01-25 16:00:18 PST 
Comment on attachment 124026 [details]
Patch for landing

Clearing flags on attachment: 124026

Committed r105938: <http://trac.webkit.org/changeset/105938>
Comment 11 WebKit Review Bot 2012-01-25 16:00:23 PST 
All reviewed patches have been landed.  Closing bug.