Bug 74349 - De-virtualize destructors part 5
Summary: De-virtualize destructors part 5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 74348
Blocks: 74331 74350
  Show dependency tree / graph
 
Reported: 2011-12-12 14:56 PST by Mark Hahnenberg
Modified: 2011-12-18 12:23 PST (History)
3 users (show)

See Also:

Attachments
De-virtualize destructors part 5 (18.65 KB, patch)
2011-12-12 15:03 PST, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-12-12 14:56:38 PST 
Same as bug 74341, just moving the static destroy functions down another level in the hierarchy and leaving behind any necessary destroy functions.
Comment 1 Mark Hahnenberg 2011-12-12 15:03:41 PST 
Created attachment 118869 [details]
De-virtualize destructors part 5

No changelog (see bug 74331).
Comment 2 Geoffrey Garen 2011-12-12 15:32:33 PST 
Comment on attachment 118869 [details]
De-virtualize destructors part 5

View in context: https://bugs.webkit.org/attachment.cgi?id=118869&action=review

r=me

> Source/WebCore/bindings/js/JSDOMBinding.h:81
> +        static JSC::Structure* createStructure(JSC::JSGlobalData& globalData, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)

Your ChangeLog should explain why this is needed.