Bug 74345 – WebAudio: Use float instead of double values for gain operations.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

WebAudio: Optimize processWithGainFromMonoStereo.

[Jer Noble]

Created attachment 118866 [details]
Patch

[Jer Noble]

Created attachment 118893 [details]
Patch

Rebased patch against ToT.

[WebKit Review Bot]

Comment on attachment 118893 [details]
Patch

Attachment 118893 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10846118

[Jer Noble]

Created attachment 118923 [details]
Patch

[WebKit Review Bot]

Comment on attachment 118923 [details]
Patch

Attachment 118923 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10850160

[Jer Noble]

Created attachment 118955 [details]
Patch

Corrected order of parameters for vsma in VectorMath.cpp which was causing link errors in the Chromium build bots.

[Chris Rogers]

Hi Jer, have you seen the latest Intel patches to this same area of code?  They've landed a few changes already which seem to be optimizing the same things.

[Jer Noble]

(In reply to comment #7)
> Hi Jer, have you seen the latest Intel patches to this same area of code?  They've landed a few changes already which seem to be optimizing the same things.

I have.  Their patches don't seem to entirely overlap with mine, though a lot of the vector math additions are the same.

[Chris Rogers]

Comment on attachment 118955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118955&action=review

> Source/WebCore/platform/audio/AudioBus.cpp:-238
> -    // FIXME: Need fast path here when gain has converged on targetGain. In this case, de-zippering is no longer needed.

I believe this FIXME has already been addressed by some Intel patches - please see latest code.

> Source/WebCore/platform/audio/AudioBus.cpp:289
> +    } else if (sumToBus) {

Lines 261:289 have already been addressed with similar optimizations already landed (with macros).  Also, there's a more recent patch which seems like it's almost ready:
https://bugs.webkit.org/show_bug.cgi?id=75835

[Jer Noble]

Comment on attachment 118955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118955&action=review

>> Source/WebCore/platform/audio/AudioBus.cpp:-238
>> -    // FIXME: Need fast path here when gain has converged on targetGain. In this case, de-zippering is no longer needed.
> 
> I believe this FIXME has already been addressed by some Intel patches - please see latest code.

I'll rebase and upload a new patch.

>> Source/WebCore/platform/audio/AudioBus.cpp:289
>> +    } else if (sumToBus) {
> 
> Lines 261:289 have already been addressed with similar optimizations already landed (with macros).  Also, there's a more recent patch which seems like it's almost ready:
> https://bugs.webkit.org/show_bug.cgi?id=75835

Ditto.

[Jer Noble]

Updated title of bug now that a fix for bug #75835 has been committed.

[Jer Noble]

Created attachment 122457 [details]
Patch

[Jer Noble]

Committed r104993: <http://trac.webkit.org/changeset/104993>