WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74337
WebKit code shouldn't be calling applyCommand directly
https://bugs.webkit.org/show_bug.cgi?id=74337
Summary
WebKit code shouldn't be calling applyCommand directly
Ryosuke Niwa
Reported
2011-12-12 14:28:20 PST
CompositeEditCommands are implementation-details in WebCore and shouldn't be exposed to WebKit layer.
Attachments
cleanup
(12.86 KB, patch)
2011-12-12 14:36 PST
,
Ryosuke Niwa
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2011-12-12 14:36:26 PST
Created
attachment 118851
[details]
cleanup
Darin Adler
Comment 2
2011-12-12 14:41:52 PST
Comment on
attachment 118851
[details]
cleanup View in context:
https://bugs.webkit.org/attachment.cgi?id=118851&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2246 > + bool selectReplacement = true; > + bool smartReplace = 0; > + return frame->editor()->replaceSelectionWithText(text, selectReplacement, smartReplace);
We should change this to flags or enums, longer term. Also, we should use false instead of 0.
Ryosuke Niwa
Comment 3
2011-12-12 14:48:45 PST
Comment on
attachment 118851
[details]
cleanup View in context:
https://bugs.webkit.org/attachment.cgi?id=118851&action=review
Thanks for the review!
>> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2246 >> + return frame->editor()->replaceSelectionWithText(text, selectReplacement, smartReplace); > > We should change this to flags or enums, longer term. Also, we should use false instead of 0.
Oops, 0 was my mistake. Will fix.
> Source/WebKit/chromium/src/WebFrameImpl.cpp:1125 > + bool selectReplacement = true;
Oops, this should be false also. Will fix before landing it.
Ryosuke Niwa
Comment 4
2011-12-12 14:53:39 PST
Committed
r102627
: <
http://trac.webkit.org/changeset/102627
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug