Bug 74326 - WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
Summary: WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 13:38 PST by Jer Noble
Modified: 2012-01-12 14:51 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2011-12-12 13:42 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2011-12-12 15:57 PST, Jer Noble
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-12-12 13:38:49 PST
AudioBus::loadPlatformResource should mmap file on Mac port.
Comment 1 Jer Noble 2011-12-12 13:42:40 PST
Created attachment 118836 [details]
Patch
Comment 2 Jer Noble 2011-12-12 15:57:36 PST
Created attachment 118896 [details]
Patch

Rebased patch against ToT.
Comment 3 Jer Noble 2012-01-12 14:13:45 PST
Committed r104858: <http://trac.webkit.org/changeset/104858>
Comment 4 Ryosuke Niwa 2012-01-12 14:36:52 PST
This patch broke Snow Leopard builds. NSDataReadingMappedIfSafe isn't defined in 10.6 and earlier versions of Mac OS X.
Comment 6 Jer Noble 2012-01-12 14:51:36 PST
Fix coming.