Bug 74320 – Chromium Windows (Tests) is failing to build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Ryosuke Niwa]

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/21854/steps/compile-webkit/logs/stdio

4>e:\google-windows-2\chromium-win-release-tests\build\Source\WebKit\chromium\build\Release\obj\global_intermediate\webkit\third_party/WebKit/Source/WebKit/chromium/public/platform/WebSocketStreamHandleClient.h(2) : fatal error C1083: Cannot open include file: '../../../../../../../../../../../..\public\platform\WebSocketStreamHandleClient.h': No such file or directory

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29

Interestingly enough, Chromium Win Release is building fine:
http://build.webkit.org/builders/Chromium%20Win%20Release

[Tony Chang]

I rdesktop'ed into the machine.  The file is there and the path is correct.

I tried a debug build and it works fine.

The error doesn't show up in Error List.

My best guess is that the filename is too long for Visual Studios?

[Tony Chang]

I renamed the build directory from chromium-win-release-tests to 'c' and I was able to build the file in Visual Studio :(

[Marc-Antoine Ruel]

e:\google-windows-2\chromium-win-release-tests\build\Source\WebKit\chromium\build\Release\obj\global_intermediate\webkit\third_party/WebKit/Source/WebKit/chromium/public/platform/../../../../../../../../../../../..\public\platform\WebSocketStreamHandleClient.h

is 261 chars. Bingo!

Use slavebuilddir property in the build master to rename the slave checkout to a shorter name as a temporary (e.g. permanent) workaround. That requires a master restart though.

[Ryosuke Niwa]

We can just rename google-windows-2 to something else.

[Marc-Antoine Ruel]

We use e:\b\

It'll help for 15 chars but I would also do the slavebuilddir trick to shorten the name even more.

[Tony Chang]

Ok, I will rename google-windows-2 to b and I think I can change the generated include path to be 'public\platform\WebSocketStreamHandleClient.h'.  I think Source/WebKit/chromium is in the include path already.  That saves 36 characters.

[Tony Chang]

Created attachment 119481 [details]
Patch

[Kenneth Russell]

Comment on attachment 119481 [details]
Patch

Looks good to me as long as it's been tested.

[Tony Chang]

(In reply to comment #8)
> (From update of attachment 119481 [details])
> Looks good to me as long as it's been tested.

I tested on my machine, but I want to make sure this makes it through EWS too.

[WebKit Review Bot]

Comment on attachment 119481 [details]
Patch

Clearing flags on attachment: 119481

Committed r103021: <http://trac.webkit.org/changeset/103021>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.