RESOLVED FIXED 74281
[Qt] Fix skip list search path and expected file search path in ORWT 
https://bugs.webkit.org/show_bug.cgi?id=74281
Summary [Qt] Fix skip list search path and expected file search path in ORWT
Ádám Kallai
Reported 2011-12-12 03:35:59 PST
Expected file search path are incorrect and Qt version is not support in ORWT. (Qt 4.8, Qt 5.0)
Attachments
proposed patch (4.64 KB, patch)
2011-12-12 06:52 PST, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ádám Kallai
Comment 1 2011-12-12 06:52:32 PST
Created attachment 118781 [details] proposed patch During searching the expected files' paths the general preference order on qt platform is: /(qt-mac/qt-win/qt-linux)/ , qt version /(qt-4.8/qt-5.0)/ , qt and generic by default. For example: qt-linux -> qt-5.0 -> qt -> generic If we call ORWT with -2 parameter the result is for example: qt-wk2 -> qt-linux -> qt-5.0 -> qt -> generic Now these things are similar to NRWT: * expected search path are correct * printing all used skipped list and expected search path in verbose mode.
Csaba Osztrogonác
Comment 2 2011-12-12 08:20:02 PST
Comment on attachment 118781 [details] proposed patch great work, r=me.
WebKit Review Bot
Comment 3 2011-12-12 09:48:48 PST
Comment on attachment 118781 [details] proposed patch Clearing flags on attachment: 118781 Committed r102594: <http://trac.webkit.org/changeset/102594>
WebKit Review Bot
Comment 4 2011-12-12 09:48:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.