Bug 74268 – prepare-ChangeLog should not include a reference file ('xxx-expected.html') used by reftests as a test file.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Hayato Ito]

If a change contains reftests, the output of prepare-changelog includes both a test file (xxx.html) and a reference file (xxx-expected.html) as follows:

        Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
               fast/dom/shadow/dynamically-created-shadow-root.html:


That should be:

        Tests: fast/dom/shadow/dynamically-created-shadow-root.html:

[Hayato Ito]

Created attachment 118749 [details]
exclude reffile

[Ryosuke Niwa]

Comment on attachment 118749 [details]
exclude reffile

View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review

> Tools/Scripts/prepare-ChangeLog:1619
>                         && !scalar(grep(/^resources$/i, @components))

This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests.

[Hayato Ito]

Thank you for the review.

(In reply to comment #2)
> (From update of attachment 118749 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review
> 
> > Tools/Scripts/prepare-ChangeLog:1619
> >                         && !scalar(grep(/^resources$/i, @components))
> 
> This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests.

Yeah, this is not perfect. But I'd like to delay handling such names as '-ref, -noref, etc' since there is no strict usable rule to detect these names in easy way.
It might be better to file another bug to handle such cases.

As for '-expected.html' and '-expected-mismatch.html', this is clear and present issue. So this must be fixed. Later we might have to handle such cases, '-ref, ...etc'.

[Hayato Ito]

I've filed another bug in https://bugs.webkit.org/show_bug.cgi?id=74579.

[Hayato Ito]

Created attachment 140481 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 140481 [details]
Patch for landing

Clearing flags on attachment: 140481

Committed r116279: <http://trac.webkit.org/changeset/116279>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.