Bug 74266 - [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor
Summary: [Refactoring] In prepare-ChangeLog, move into a method the top-level code to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 73531
  Show dependency treegraph
 
Reported: 2011-12-11 23:25 PST by Kentaro Hara
Modified: 2011-12-12 08:55 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.61 KB, patch)
2011-12-11 23:33 PST, Kentaro Hara
rniwa: review+
Details | Formatted Diff | Diff
patch for commit (5.61 KB, patch)
2011-12-11 23:43 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-12-11 23:25:33 PST
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog.

FYI: After this patch is landed, I'll work on removing all global variables.
Comment 1 Kentaro Hara 2011-12-11 23:33:07 PST
Created attachment 118741 [details]
Patch
Comment 2 Ryosuke Niwa 2011-12-11 23:41:16 PST
Comment on attachment 118741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review

> Tools/ChangeLog:3
> +        [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor

Split this line into two lines?
Comment 3 Kentaro Hara 2011-12-11 23:43:17 PST
Created attachment 118742 [details]
patch for commit
Comment 4 Kentaro Hara 2011-12-11 23:43:42 PST
(In reply to comment #2)
> (From update of attachment 118741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review
> 
> > Tools/ChangeLog:3
> > +        [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor
> 
> Split this line into two lines?

Done. Thanks.
Comment 5 WebKit Review Bot 2011-12-12 00:59:15 PST
Comment on attachment 118742 [details]
patch for commit

Clearing flags on attachment: 118742

Committed r102562: <http://trac.webkit.org/changeset/102562>
Comment 6 David Kilzer (:ddkilzer) 2011-12-12 08:55:49 PST
Manually marking bug as RESOLVED/FIXED.