Bug 74266 – [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kentaro Hara]

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog.

FYI: After this patch is landed, I'll work on removing all global variables.

[Kentaro Hara]

Created attachment 118741 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 118741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review

> Tools/ChangeLog:3
> +        [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor

Split this line into two lines?

[Kentaro Hara]

Created attachment 118742 [details]
patch for commit

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 118741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review
> 
> > Tools/ChangeLog:3
> > +        [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor
> 
> Split this line into two lines?

Done. Thanks.

[WebKit Review Bot]

Comment on attachment 118742 [details]
patch for commit

Clearing flags on attachment: 118742

Committed r102562: <http://trac.webkit.org/changeset/102562>

[David Kilzer (:ddkilzer)]

Manually marking bug as RESOLVED/FIXED.