Bug 74257 - [Refactoring] In prepare-ChangeLog, move top-level code to resolve conflicted ChangeLogs into a method
Summary: [Refactoring] In prepare-ChangeLog, move top-level code to resolve conflicted...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 73531
  Show dependency treegraph
 
Reported: 2011-12-11 15:56 PST by Kentaro Hara
Modified: 2011-12-12 08:47 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.13 KB, patch)
2011-12-11 16:04 PST, Kentaro Hara
rniwa: review+
Details | Formatted Diff | Diff
rebased patch for commit (5.12 KB, patch)
2011-12-11 21:09 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-12-11 15:56:22 PST
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest/ manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog.
Comment 1 Kentaro Hara 2011-12-11 16:04:53 PST
Created attachment 118716 [details]
Patch
Comment 2 Ryosuke Niwa 2011-12-11 20:51:46 PST
Comment on attachment 118716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118716&action=review

> Tools/ChangeLog:13
> +        * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs into resolveConflictedChangeLogs().

This line seems too long. Please add line breaks as needed.

> Tools/Scripts/prepare-ChangeLog:458
> +    if (@conflictedChangeLogs) {

It seems like we can exit early here.
Comment 3 Kentaro Hara 2011-12-11 21:09:53 PST
Created attachment 118728 [details]
rebased patch for commit
Comment 4 Kentaro Hara 2011-12-11 21:11:19 PST
(In reply to comment #2)
> (From update of attachment 118716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118716&action=review
> 
> > Tools/ChangeLog:13
> > +        * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs into resolveConflictedChangeLogs().
> 
> This line seems too long. Please add line breaks as needed.

Done.

> > Tools/Scripts/prepare-ChangeLog:458
> > +    if (@conflictedChangeLogs) {
> 
> It seems like we can exit early here.

Done.
Comment 5 WebKit Review Bot 2011-12-11 23:08:12 PST
Comment on attachment 118728 [details]
rebased patch for commit

Clearing flags on attachment: 118728

Committed r102559: <http://trac.webkit.org/changeset/102559>
Comment 6 David Kilzer (:ddkilzer) 2011-12-12 08:47:41 PST
Manually marking as RESOLVED/FIXED since the bot didn't seem to do it.