WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74248
Remove OS(SYMBIAN) block from Settings constructor.
https://bugs.webkit.org/show_bug.cgi?id=74248
Summary
Remove OS(SYMBIAN) block from Settings constructor.
Andreas Kling
Reported
2011-12-10 16:38:32 PST
SSIA
Attachments
Patch
(1.17 KB, patch)
2011-12-10 16:40 PST
,
Andreas Kling
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-12-10 16:40:51 PST
Created
attachment 118699
[details]
Patch
Benjamin Poulain
Comment 2
2011-12-10 18:54:45 PST
Comment on
attachment 118699
[details]
Patch I am ok with this particular change but do you know why we have passwordEchoEnabled at all? Maybe we can remove that setting entierly?
Benjamin Poulain
Comment 3
2011-12-10 19:06:31 PST
Ok, that was added in 93656. This code comes from iOS, so it makes sense to keep it.
Andreas Kling
Comment 4
2011-12-11 11:34:15 PST
Committed
r102539
: <
http://trac.webkit.org/changeset/102539
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug