Bug 74247 - Web Inspector: [protocol] alter some type names generated from Inspector.json
Summary: Web Inspector: [protocol] alter some type names generated from Inspector.json
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-12-10 16:17 PST by Peter Rybin
Modified: 2011-12-11 12:44 PST (History)
11 users (show)

See Also:

Patch (5.79 KB, patch)
2011-12-10 16:30 PST, Peter Rybin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2011-12-10 16:17:06 PST
CodeGeneratorInspector.py takes type names straight from Inspector.json. However it should be more careful with some of them because they may conflict with already existing names (notable defines that are namespace-agnostic). See commend about RGBA in https://bugs.webkit.org/show_bug.cgi?id=72835
Comment 1 Peter Rybin 2011-12-10 16:30:07 PST
Created attachment 118697 [details]
Comment 2 Ilya Tikhonovsky 2011-12-11 12:44:44 PST
Comment on attachment 118697 [details]

Clearing flags on attachment: 118697

Committed r102541: <http://trac.webkit.org/changeset/102541>
Comment 3 Ilya Tikhonovsky 2011-12-11 12:44:52 PST
All reviewed patches have been landed.  Closing bug.