Bug 74244 - v8 benchmark takes 12-13 million function call slow paths due to extra arguments
Summary: v8 benchmark takes 12-13 million function call slow paths due to extra arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-10 15:20 PST by Geoffrey Garen
Modified: 2011-12-11 16:35 PST (History)
0 users

See Also:


Attachments
Patch (139.56 KB, patch)
2011-12-11 14:17 PST, Geoffrey Garen
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-12-10 15:20:12 PST
v8 benchmark takes 12-13 million function call slow paths due to extra arguments
Comment 1 Geoffrey Garen 2011-12-11 14:17:30 PST
Created attachment 118713 [details]
Patch
Comment 2 Oliver Hunt 2011-12-11 15:01:34 PST
Comment on attachment 118713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118713&action=review

r=me, though it would be good to verify kraken + sunspider are okay

> Source/JavaScriptCore/interpreter/Interpreter.h:88
> -    enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 32 };
> +    enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 16 };
>  #else
> -    enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 32 };
> +    enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 16 };

Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/
Comment 3 Geoffrey Garen 2011-12-11 16:29:27 PST
> r=me, though it would be good to verify kraken + sunspider are okay

Neutral on Kraken+SunSpider.

> Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/

Yeah. I think we should also find the giant object(s) we're putting on the stack and put them on the heap instead.
Comment 4 Geoffrey Garen 2011-12-11 16:35:57 PST
Committed r102545: <http://trac.webkit.org/changeset/102545>