Bug 74239 - REGRESSION (r80438): First word on a line or after collapsed space may not be hyphenated even though it should
Summary: REGRESSION (r80438): First word on a line or after collapsed space may not be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: mitz
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-12-10 11:09 PST by mitz
Modified: 2011-12-12 17:00 PST (History)
1 user (show)

See Also:


Attachments
Check whether the first character of the prefix before the hyphen is a space when deciding if the prefix is long enough (6.73 KB, patch)
2011-12-10 11:16 PST, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-12-10 11:09:12 PST
REGRESSION (r80438): First word on a line or after collapsed space may not be hyphenated even though it should
Comment 1 mitz 2011-12-10 11:10:55 PST
<rdar://problem/10561285>
Comment 2 mitz 2011-12-10 11:16:35 PST
Created attachment 118693 [details]
Check whether the first character of the prefix before the hyphen is a space when deciding if the prefix is long enough
Comment 3 mitz 2011-12-11 11:07:14 PST
Fixed in <http://trac.webkit.org/r102538>.
Comment 4 Ryosuke Niwa 2011-12-12 16:56:40 PST
The test is failing on SL:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102627%20(35418)/fast/text/hyphenate-limit-lines-pretty-diff.html

Should we just rebaseline? The diff looks similar to the change you made.
Comment 5 mitz 2011-12-12 17:00:47 PST
(In reply to comment #4)
> The test is failing on SL:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r102627%20(35418)/fast/text/hyphenate-limit-lines-pretty-diff.html
> 
> Should we just rebaseline? The diff looks similar to the change you made.

Yeah, the new results seem right.