RESOLVED FIXED 74218
Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess 
https://bugs.webkit.org/show_bug.cgi?id=74218
Summary Expose a WKConnectionRef which represents the connection to/from the WebProce...
Sam Weinig
Reported 2011-12-09 14:43:56 PST
Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
Attachments
Patch (23.45 KB, patch)
2011-12-09 14:48 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-12-09 14:48:52 PST
Created attachment 118647 [details] Patch
Anders Carlsson
Comment 2 2011-12-09 14:52:39 PST
Comment on attachment 118647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118647&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:59 > +WKConnectionRef WKBundleGetConnectionToApplication(WKBundleRef bundleRef) Why does this need to take a parameter? Also, I like WKBundleGetApplicationConnection better.
WebKit Review Bot
Comment 3 2011-12-09 14:53:11 PST
Attachment 118647 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp:78: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/WebProcess/WebConnectionToUIProcess.cpp:76: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 4 2011-12-09 14:57:28 PST
(In reply to comment #2) > (From update of attachment 118647 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118647&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:59 > > +WKConnectionRef WKBundleGetConnectionToApplication(WKBundleRef bundleRef) > > Why does this need to take a parameter? Also, I like WKBundleGetApplicationConnection better. I prefer adding the bundle so that if we ever support more than one bundle it has an easier transition both in code and mindset. Also, because all/most of the other ones do. I'll change the name though.
Sam Weinig
Comment 5 2011-12-09 15:45:55 PST
Committed r102484: <http://trac.webkit.org/changeset/102484>
Note You need to log in before you can comment on or make changes to this bug.