[chromium] Add worldId parameter to allowScriptExtension()
Created attachment 118640 [details] Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
The chromium side of this patch is here: http://codereview.chromium.org/8872053/
Comment on attachment 118640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118640&action=review > Source/WebKit/chromium/public/WebPermissionClient.h:77 > + virtual bool allowScriptExtension(WebFrame*, const WebString& extensionName, int extensionGroup, int worldId) { return true; } usually we make the default implementation of the new method call the old method. that helps us keep the system working while we transition chrome over to impl the new method.
Created attachment 119568 [details] Patch
(In reply to comment #4) > (From update of attachment 118640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118640&action=review > > > Source/WebKit/chromium/public/WebPermissionClient.h:77 > > + virtual bool allowScriptExtension(WebFrame*, const WebString& extensionName, int extensionGroup, int worldId) { return true; } > > usually we make the default implementation of the new method call the old method. > that helps us keep the system working while we transition chrome over to impl > the new method. Cool, done.
Comment on attachment 119568 [details] Patch Rejecting attachment 119568 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 114686 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 114686. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10914668
Created attachment 119781 [details] Patch for landing
Comment on attachment 119781 [details] Patch for landing Clearing flags on attachment: 119781 Committed r103195: <http://trac.webkit.org/changeset/103195>
All reviewed patches have been landed. Closing bug.