Bug 74182 - [EFL] Add context menus for EWebLauncher
Summary: [EFL] Add context menus for EWebLauncher
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 74179
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-09 07:18 PST by Michal Pakula vel Rutka
Modified: 2013-05-22 02:20 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (13.34 KB, patch)
2011-12-09 07:45 PST, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
reupload previous file (13.34 KB, patch)
2011-12-12 04:03 PST, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
new patch (13.23 KB, patch)
2012-04-23 03:43 PDT, Michal Pakula vel Rutka 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2011-12-09 07:18:12 PST 
Adds elementary context menus for EWebLauncher. Also I have added a parent menu to Ewk_Context_Menu structure for better handling by elementary context menu callbacks.
Comment 1 Michal Pakula vel Rutka 2011-12-09 07:45:43 PST 
Created attachment 118577 [details]
proposed patch
Comment 2 Michal Pakula vel Rutka 2011-12-12 04:03:52 PST 
Created attachment 118774 [details]
reupload previous file
Comment 3 Michal Pakula vel Rutka 2011-12-12 06:42:43 PST 
The patch does not apply because it needs bug's 74179 patch to be applied first.
Comment 4 Gyuyoung Kim 2011-12-18 23:58:25 PST 
EWS couldn't run test because of failing to merge. Could you submit new patch based on latest WebKit trunk ?
Comment 5 Michal Pakula vel Rutka 2011-12-19 02:21:16 PST 
The problem is this patch needs https://bugs.webkit.org/show_bug.cgi?id=74179 to work, so I it is dependent from from it. It will apply only if 74182 will be applied first.
Adding dependency from 74179 here does not changed anything at all - if you know a method to force applying 74179 before applying this one please let me know.
Comment 6 Michal Pakula vel Rutka 2012-04-23 03:43:39 PDT 
Created attachment 138322 [details]
new patch

uploaded new patch adding elementary to efl jhbuild script and matching new context menu implementation from 74179
Comment 7 Gyuyoung Kim 2012-04-23 05:18:21 PDT 
Comment on attachment 138322 [details]
new patch

Attachment 138322 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12511164
Comment 8 Michal Pakula vel Rutka 2013-05-22 02:20:40 PDT 
We are not supporting new features in WebKit1 anymore.