Bug 74162 - Implement CSS resize property in CSSStyleApplyProperty.
Summary: Implement CSS resize property in CSSStyleApplyProperty.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 21:01 PST by Luke Macpherson
Modified: 2011-12-11 16:24 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.67 KB, patch)
2011-12-08 21:23 PST, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch for landing (4.67 KB, patch)
2011-12-11 15:07 PST, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-12-08 21:01:35 PST
Implement CSS resize property in CSSStyleApplyProperty.
Comment 1 Luke Macpherson 2011-12-08 21:23:33 PST
Created attachment 118528 [details]
Patch
Comment 2 Julien Chaffraix 2011-12-09 13:53:54 PST
Comment on attachment 118528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160
> +        if (!primitiveValue->getIdent())
> +            return;
> +
> +        EResize r = RESIZE_NONE;
> +        switch (primitiveValue->getIdent()) {
> +        case 0:
> +            return;

This was not in the original code. It also looks like it is doing exactly the check above so it should be removed.
Comment 3 Luke Macpherson 2011-12-11 14:35:37 PST
Comment on attachment 118528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160
>> +            return;
> 
> This was not in the original code. It also looks like it is doing exactly the check above so it should be removed.

Indeed. I moved it into the switch to avoid the overhead of calling the getter (which actually does some work) multiple times, but evidently forgot to remove the existing check. Thanks for spotting this.
Comment 4 Luke Macpherson 2011-12-11 15:07:47 PST
Created attachment 118714 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-12-11 16:24:46 PST
Comment on attachment 118714 [details]
Patch for landing

Clearing flags on attachment: 118714

Committed r102544: <http://trac.webkit.org/changeset/102544>
Comment 6 WebKit Review Bot 2011-12-11 16:24:50 PST
All reviewed patches have been landed.  Closing bug.