Bug 74150 - chromium port - remove nacl hack in DEPS and gyp_webkit
Summary: chromium port - remove nacl hack in DEPS and gyp_webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 17:49 PST by Dirk Pranke
Modified: 2011-12-13 18:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2011-12-08 17:50 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
merge to r102474 (2.18 KB, patch)
2011-12-09 14:20 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
merge to r102718 (2.14 KB, patch)
2011-12-13 16:26 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-12-08 17:49:56 PST 
chromium port - remove nacl hack in DEPS/gyp_webkit
Comment 1 Dirk Pranke 2011-12-08 17:50:47 PST 
Created attachment 118503 [details]
Patch
Comment 2 noel gordon 2011-12-09 03:31:47 PST 
SGTM.
Comment 3 Tony Chang 2011-12-09 09:54:58 PST 
Comment on attachment 118503 [details]
Patch

I would feel safer about this patch if it passed on the ews bot (or land it with the cq).
Comment 4 Dirk Pranke 2011-12-09 14:20:57 PST 
Created attachment 118638 [details]
merge to r102474
Comment 5 Dirk Pranke 2011-12-09 14:21:33 PST 
someone rolled the DEPS in the meantime and that caused a merge conflict ... I've updated the patch and resubmitted it to EWS.
Comment 6 Dirk Pranke 2011-12-13 16:26:00 PST 
Created attachment 119104 [details]
merge to r102718
Comment 7 Tony Chang 2011-12-13 16:47:14 PST 
Comment on attachment 119104 [details]
merge to r102718

Still seems fine.
Comment 8 noel gordon 2011-12-13 17:05:21 PST 
Assuming the affected ews are happy.
Comment 9 Dirk Pranke 2011-12-13 18:32:52 PST 
Comment on attachment 119104 [details]
merge to r102718

Clearing flags on attachment: 119104

Committed r102727: <http://trac.webkit.org/changeset/102727>
Comment 10 Dirk Pranke 2011-12-13 18:32:55 PST 
All reviewed patches have been landed.  Closing bug.