Bug 74137 - Update test_expectations for chromium
Summary: Update test_expectations for chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 16:14 PST by Jacob Goldstein
Modified: 2011-12-10 11:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.40 KB, patch)
2011-12-08 16:58 PST, Jacob Goldstein
no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2011-12-08 17:06 PST, Jacob Goldstein
rniwa: review-
Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2011-12-08 17:38 PST, Jacob Goldstein
no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2011-12-08 18:17 PST, Jacob Goldstein
no flags Details | Formatted Diff | Diff
Patch (5.15 KB, patch)
2011-12-08 18:21 PST, Jacob Goldstein
rniwa: review+
stearns: commit-queue-
Details | Formatted Diff | Diff
patch take 6 (6.00 KB, patch)
2011-12-09 14:50 PST, Alan Stearns
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Goldstein 2011-12-08 16:14:41 PST
Update test_expectations.txt for chromium to include all non-pixel fast/regions tests
Comment 1 Jacob Goldstein 2011-12-08 16:58:59 PST
Created attachment 118491 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-08 17:01:55 PST
Attachment 118491 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Last 3072 characters of output:
.txt:3205:  Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3206:  Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical-rl.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3207:  Missing expectations BUGWK74137 : fast/regions/flowed-content-transform-bounding-client-rect.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3208:  Missing expectations BUGWK74137 : fast/regions/hit-test-float.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3209:  Missing expectations BUGWK74137 : fast/regions/no-split-line-box.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3210:  Missing expectations BUGWK74137 : fast/regions/parse-incomplete-region-rule.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3211:  Missing expectations BUGWK74137 : fast/regions/parse-region-style-rule.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3212:  Missing expectations BUGWK74137 : fast/regions/region-element-display-restriction.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3213:  Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-attach-flow.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3214:  Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-detach-flow.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3215:  Missing expectations BUGWK74137 : fast/regions/text-region-breaks-expected.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3216:  Missing expectations BUGWK74137 : fast/regions/text-region-split-after-resize.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3217:  Missing expectations BUGWK74137 : fast/regions/text-region-split.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3218:  Missing expectations BUGWK74137 : fast/regions/text-region-split-horizontal-bt.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3219:  Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3220:  Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical-rl.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3221:  Missing expectations BUGWK74137 : fast/regions/webkit-flow-parsing.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3222:  Missing expectations BUGWK74137 : fast/regions/webkit-region-overflow-parsing.html PASS  [test/expectations] [5]
Total errors found: 34 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jacob Goldstein 2011-12-08 17:06:19 PST
Created attachment 118495 [details]
Patch

Update to add missing "PASS" for fast/region tests
Comment 4 Ryosuke Niwa 2011-12-08 17:08:45 PST
Comment on attachment 118495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118495&action=review

> LayoutTests/platform/chromium/test_expectations.txt:3190
> +BUGWK73581 : fast/regions/content-flowed-into-regions-dynamically-added.html PASS

You need = before PASS.
Comment 5 WebKit Review Bot 2011-12-08 17:08:50 PST
Attachment 118495 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Last 3072 characters of output:
.txt:3205:  Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3206:  Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical-rl.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3207:  Missing expectations BUGWK74137 : fast/regions/flowed-content-transform-bounding-client-rect.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3208:  Missing expectations BUGWK74137 : fast/regions/hit-test-float.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3209:  Missing expectations BUGWK74137 : fast/regions/no-split-line-box.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3210:  Missing expectations BUGWK74137 : fast/regions/parse-incomplete-region-rule.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3211:  Missing expectations BUGWK74137 : fast/regions/parse-region-style-rule.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3212:  Missing expectations BUGWK74137 : fast/regions/region-element-display-restriction.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3213:  Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-attach-flow.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3214:  Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-detach-flow.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3215:  Missing expectations BUGWK74137 : fast/regions/text-region-breaks-expected.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3216:  Missing expectations BUGWK74137 : fast/regions/text-region-split-after-resize.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3217:  Missing expectations BUGWK74137 : fast/regions/text-region-split.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3218:  Missing expectations BUGWK74137 : fast/regions/text-region-split-horizontal-bt.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3219:  Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3220:  Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical-rl.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3221:  Missing expectations BUGWK74137 : fast/regions/webkit-flow-parsing.html PASS  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:3222:  Missing expectations BUGWK74137 : fast/regions/webkit-region-overflow-parsing.html PASS  [test/expectations] [5]
Total errors found: 34 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tony Chang 2011-12-08 17:12:11 PST
You can run new-run-webkit-tests --lint-test-files to verify the syntax.
Comment 7 Jacob Goldstein 2011-12-08 17:38:13 PST
Created attachment 118501 [details]
Patch

Updated to correct syntax errors
Comment 8 Ryosuke Niwa 2011-12-08 17:39:43 PST
Comment on attachment 118501 [details]
Patch

Wait... it doesn't make sense sense to add = PASS. Why are we doing that?
Comment 9 WebKit Review Bot 2011-12-08 17:42:43 PST
Attachment 118501 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

ERROR: FAILURES FOR <lucid, x86_64, release, cpu> in LayoutTests/platform/chromium/test_expectations.txt
ERROR: Line:3211 Path does not exist. fast/regions/parse-region-style-rule.html
ERROR: Line:3215 Path does not exist. fast/regions/text-region-breaks-expected.html
LayoutTests/platform/chromium/test_expectations.txt:3211:  Path does not exist. fast/regions/parse-region-style-rule.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3215:  Path does not exist. fast/regions/text-region-breaks-expected.html  [test/expectations] [2]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Jacob Goldstein 2011-12-08 18:17:40 PST
Created attachment 118508 [details]
Patch

- Updated file to remove expected passes and instead list potential failures from fast/regions
- Ran "check-webkit-style" and "...--lint-test-files" to verify syntax, no errors reported
Comment 11 Jacob Goldstein 2011-12-08 18:21:02 PST
Created attachment 118509 [details]
Patch

Updated to remove "MISSING" as it is a subset of FAIL
Comment 12 Alan Stearns 2011-12-08 18:21:23 PST
rniwa, Jacob started adding = PASS lines for non-pixel tests. The fast/regions directory itself is still set to = PASS FAIL MISSING. The idea was to get these tests running on Chromium sooner, but I gave Jacob the wrong syntax to use (the first two patches are my fault).

Once we're done there will be one fast/regions entry set = PASS, with whatever leftover pixel results we need.
Comment 13 Alan Stearns 2011-12-09 14:14:51 PST
The chromium and commit bots complained about missing expectations for some tests with a PASS FAIL entry, so I'm switching them back to PASS FAIL MISSING
Comment 14 Alan Stearns 2011-12-09 14:50:10 PST
Created attachment 118648 [details]
patch take 6
Comment 15 WebKit Review Bot 2011-12-10 11:33:36 PST
Comment on attachment 118648 [details]
patch take 6

Clearing flags on attachment: 118648

Committed r102524: <http://trac.webkit.org/changeset/102524>
Comment 16 WebKit Review Bot 2011-12-10 11:33:41 PST
All reviewed patches have been landed.  Closing bug.