74137 – Update test_expectations for chromium

RESOLVED FIXED 74137

Update test_expectations for chromium

https://bugs.webkit.org/show_bug.cgi?id=74137

Summary Update test_expectations for chromium

Jacob Goldstein

Reported 2011-12-08 16:14:41 PST

Update test_expectations.txt for chromium to include all non-pixel fast/regions tests

Attachments
Patch (3.40 KB, patch) 2011-12-08 16:58 PST, Jacob Goldstein	no flags	Details Formatted Diff Diff
Patch (3.42 KB, patch) 2011-12-08 17:06 PST, Jacob Goldstein	rniwa: review-	Details Formatted Diff Diff
Patch (3.48 KB, patch) 2011-12-08 17:38 PST, Jacob Goldstein	no flags	Details Formatted Diff Diff
Patch (5.54 KB, patch) 2011-12-08 18:17 PST, Jacob Goldstein	no flags	Details Formatted Diff Diff
Patch (5.15 KB, patch) 2011-12-08 18:21 PST, Jacob Goldstein	rniwa: review+ stearns: commit-queue-	Details Formatted Diff Diff
patch take 6 (6.00 KB, patch) 2011-12-09 14:50 PST, Alan Stearns	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jacob Goldstein

Comment 1 2011-12-08 16:58:59 PST

Created attachment 118491 [details] Patch

WebKit Review Bot

Comment 2 2011-12-08 17:01:55 PST

Attachment 118491 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: .txt:3205: Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3206: Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical-rl.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3207: Missing expectations BUGWK74137 : fast/regions/flowed-content-transform-bounding-client-rect.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3208: Missing expectations BUGWK74137 : fast/regions/hit-test-float.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3209: Missing expectations BUGWK74137 : fast/regions/no-split-line-box.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3210: Missing expectations BUGWK74137 : fast/regions/parse-incomplete-region-rule.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3211: Missing expectations BUGWK74137 : fast/regions/parse-region-style-rule.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3212: Missing expectations BUGWK74137 : fast/regions/region-element-display-restriction.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3213: Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-attach-flow.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3214: Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-detach-flow.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3215: Missing expectations BUGWK74137 : fast/regions/text-region-breaks-expected.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3216: Missing expectations BUGWK74137 : fast/regions/text-region-split-after-resize.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3217: Missing expectations BUGWK74137 : fast/regions/text-region-split.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3218: Missing expectations BUGWK74137 : fast/regions/text-region-split-horizontal-bt.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3219: Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3220: Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical-rl.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3221: Missing expectations BUGWK74137 : fast/regions/webkit-flow-parsing.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3222: Missing expectations BUGWK74137 : fast/regions/webkit-region-overflow-parsing.html PASS [test/expectations] [5] Total errors found: 34 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jacob Goldstein

Comment 3 2011-12-08 17:06:19 PST

Created attachment 118495 [details] Patch Update to add missing "PASS" for fast/region tests

Ryosuke Niwa

Comment 4 2011-12-08 17:08:45 PST

Comment on attachment 118495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118495&action=review > LayoutTests/platform/chromium/test_expectations.txt:3190 > +BUGWK73581 : fast/regions/content-flowed-into-regions-dynamically-added.html PASS You need = before PASS.

WebKit Review Bot

Comment 5 2011-12-08 17:08:50 PST

Attachment 118495 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: .txt:3205: Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3206: Missing expectations BUGWK74137 : fast/regions/flowed-content-bounding-client-rect-vertical-rl.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3207: Missing expectations BUGWK74137 : fast/regions/flowed-content-transform-bounding-client-rect.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3208: Missing expectations BUGWK74137 : fast/regions/hit-test-float.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3209: Missing expectations BUGWK74137 : fast/regions/no-split-line-box.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3210: Missing expectations BUGWK74137 : fast/regions/parse-incomplete-region-rule.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3211: Missing expectations BUGWK74137 : fast/regions/parse-region-style-rule.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3212: Missing expectations BUGWK74137 : fast/regions/region-element-display-restriction.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3213: Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-attach-flow.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3214: Missing expectations BUGWK74137 : fast/regions/region-element-dynamic-detach-flow.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3215: Missing expectations BUGWK74137 : fast/regions/text-region-breaks-expected.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3216: Missing expectations BUGWK74137 : fast/regions/text-region-split-after-resize.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3217: Missing expectations BUGWK74137 : fast/regions/text-region-split.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3218: Missing expectations BUGWK74137 : fast/regions/text-region-split-horizontal-bt.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3219: Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3220: Missing expectations BUGWK74137 : fast/regions/text-region-split-vertical-rl.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3221: Missing expectations BUGWK74137 : fast/regions/webkit-flow-parsing.html PASS [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3222: Missing expectations BUGWK74137 : fast/regions/webkit-region-overflow-parsing.html PASS [test/expectations] [5] Total errors found: 34 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tony Chang

Comment 6 2011-12-08 17:12:11 PST

You can run new-run-webkit-tests --lint-test-files to verify the syntax.

Jacob Goldstein

Comment 7 2011-12-08 17:38:13 PST

Created attachment 118501 [details] Patch Updated to correct syntax errors

Ryosuke Niwa

Comment 8 2011-12-08 17:39:43 PST

Comment on attachment 118501 [details] Patch Wait... it doesn't make sense sense to add = PASS. Why are we doing that?

WebKit Review Bot

Comment 9 2011-12-08 17:42:43 PST

Attachment 118501 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> in LayoutTests/platform/chromium/test_expectations.txt ERROR: Line:3211 Path does not exist. fast/regions/parse-region-style-rule.html ERROR: Line:3215 Path does not exist. fast/regions/text-region-breaks-expected.html LayoutTests/platform/chromium/test_expectations.txt:3211: Path does not exist. fast/regions/parse-region-style-rule.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3215: Path does not exist. fast/regions/text-region-breaks-expected.html [test/expectations] [2] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jacob Goldstein

Comment 10 2011-12-08 18:17:40 PST

Created attachment 118508 [details] Patch - Updated file to remove expected passes and instead list potential failures from fast/regions - Ran "check-webkit-style" and "...--lint-test-files" to verify syntax, no errors reported

Jacob Goldstein

Comment 11 2011-12-08 18:21:02 PST

Created attachment 118509 [details] Patch Updated to remove "MISSING" as it is a subset of FAIL

Alan Stearns

Comment 12 2011-12-08 18:21:23 PST

rniwa, Jacob started adding = PASS lines for non-pixel tests. The fast/regions directory itself is still set to = PASS FAIL MISSING. The idea was to get these tests running on Chromium sooner, but I gave Jacob the wrong syntax to use (the first two patches are my fault). Once we're done there will be one fast/regions entry set = PASS, with whatever leftover pixel results we need.

Alan Stearns

Comment 13 2011-12-09 14:14:51 PST

The chromium and commit bots complained about missing expectations for some tests with a PASS FAIL entry, so I'm switching them back to PASS FAIL MISSING

Alan Stearns

Comment 14 2011-12-09 14:50:10 PST

Created attachment 118648 [details] patch take 6

WebKit Review Bot

Comment 15 2011-12-10 11:33:36 PST

Comment on attachment 118648 [details] patch take 6 Clearing flags on attachment: 118648 Committed r102524: <http://trac.webkit.org/changeset/102524>

WebKit Review Bot

Comment 16 2011-12-10 11:33:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Mac (Intel)

OS OS X 10.6

Product WebKit

Component Tools / Tests

Assignee

Nobody

Reported

2011-12-08 16:14 PST

Modified

2011-12-10 11:33 PST History

CC List

5 users Show

URL

Keywords

Depends on

Blocks