Bug 74130 – Accessibility object searching layout tests are incomplete.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Samuel White]

Unless plans exist to deprecate the layout tests in platform/mac/accessibility/search-predicate.html the remaining tests should be implemented.

[Samuel White]

Created attachment 118478 [details]
Adds support for visited link searching.

Also, removed unimplemented frames searching as it covered by tests in platform/mac/accessibility/search-with-frames.html.

[chris fleizach]

Comment on attachment 118478 [details]
Adds support for visited link searching.

View in context: https://bugs.webkit.org/attachment.cgi?id=118478&action=review

> LayoutTests/platform/mac/accessibility/search-predicate.html:330
> +        shouldBe("resultElement.role", "'AXRole: AXLink'");

Probably also want to verify that this link is actually visited. is that possible in DRT?
also no need to define searchKey and isDirectionNext. I think you can put those directly in uiElementForSearchPredicate and save two more lines of code

[Samuel White]

Created attachment 118487 [details]
Added link verification.

Implemented suggested changes.

[chris fleizach]

Comment on attachment 118487 [details]
Added link verification.

thanks. r=me

[WebKit Review Bot]

Comment on attachment 118487 [details]
Added link verification.

Clearing flags on attachment: 118487

Committed r102421: <http://trac.webkit.org/changeset/102421>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.