Bug 74130 - Accessibility object searching layout tests are incomplete.
Summary: Accessibility object searching layout tests are incomplete.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 14:41 PST by Samuel White
Modified: 2011-12-08 19:28 PST (History)
2 users (show)

See Also:


Attachments
Adds support for visited link searching. (3.59 KB, patch)
2011-12-08 15:20 PST, Samuel White
no flags Details | Formatted Diff | Diff
Added link verification. (23.37 KB, patch)
2011-12-08 16:32 PST, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel White 2011-12-08 14:41:01 PST
Unless plans exist to deprecate the layout tests in platform/mac/accessibility/search-predicate.html the remaining tests should be implemented.
Comment 1 Samuel White 2011-12-08 15:20:02 PST
Created attachment 118478 [details]
Adds support for visited link searching.

Also, removed unimplemented frames searching as it covered by tests in platform/mac/accessibility/search-with-frames.html.
Comment 2 chris fleizach 2011-12-08 15:26:18 PST
Comment on attachment 118478 [details]
Adds support for visited link searching.

View in context: https://bugs.webkit.org/attachment.cgi?id=118478&action=review

> LayoutTests/platform/mac/accessibility/search-predicate.html:330
> +        shouldBe("resultElement.role", "'AXRole: AXLink'");

Probably also want to verify that this link is actually visited. is that possible in DRT?
also no need to define searchKey and isDirectionNext. I think you can put those directly in uiElementForSearchPredicate and save two more lines of code
Comment 3 Samuel White 2011-12-08 16:32:49 PST
Created attachment 118487 [details]
Added link verification.

Implemented suggested changes.
Comment 4 chris fleizach 2011-12-08 17:37:22 PST
Comment on attachment 118487 [details]
Added link verification.

thanks. r=me
Comment 5 WebKit Review Bot 2011-12-08 19:28:41 PST
Comment on attachment 118487 [details]
Added link verification.

Clearing flags on attachment: 118487

Committed r102421: <http://trac.webkit.org/changeset/102421>
Comment 6 WebKit Review Bot 2011-12-08 19:28:45 PST
All reviewed patches have been landed.  Closing bug.