Bug 74122 - Forced compositing mode breaks display of full-page PDFs in WK2
Summary: Forced compositing mode breaks display of full-page PDFs in WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-12-08 13:17 PST by Simon Fraser (smfr)
Modified: 2011-12-08 17:46 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.86 KB, patch)
2011-12-08 13:22 PST, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-12-08 13:17:07 PST
Forced compositing mode breaks display of full-page PDFs in WK2
Comment 1 Simon Fraser (smfr) 2011-12-08 13:22:19 PST
Created attachment 118458 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-12-08 13:23:10 PST
<rdar://problem/9550059>
Comment 3 mitz 2011-12-08 16:48:52 PST
Comment on attachment 118458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118458&action=review

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:245
> +    if (m_webPage->mainFrameHasCustomRepresentation()) {
> +        if (m_alwaysUseCompositing && m_layerTreeHost)
> +            exitAcceleratedCompositingMode();
> +    } else if (m_alwaysUseCompositing && !m_layerTreeHost)
> +        enterAcceleratedCompositingMode(0);
> +}

I think this would read better with an early return if (!m_alwaysUseCompositing). Makes it clearer that this function is only about the forced compositing case.
Comment 4 Simon Fraser (smfr) 2011-12-08 17:46:56 PST
http://trac.webkit.org/changeset/102407