Bug 74118 - Chromium DEPS roll to pick up use_skia=1 for Mac, and accompanying layout_test update
Summary: Chromium DEPS roll to pick up use_skia=1 for Mac, and accompanying layout_tes...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2011-12-08 12:20 PST by epoger
Modified: 2011-12-09 08:18 PST (History)
5 users (show)

See Also:

Patch (7.35 KB, patch)
2011-12-08 12:24 PST, epoger
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description epoger 2011-12-08 12:20:27 PST
Chromium DEPS roll past Chromium's change to use skia by default on Mac (instead of CG).

Also, layout_test changes needed to keep tests green in the face of the use_skia change.
Comment 1 epoger 2011-12-08 12:24:57 PST
Created attachment 118448 [details]
Comment 2 epoger 2011-12-08 12:28:54 PST
Comment on attachment 118448 [details]

Adam- If you agree, my plan is to do the following tomorrow morning:

1. wait for a pretty green Chrome tree
2. land a Chromium change setting use_skia=1
3. modify the chromium_rev in this patch to the rev # landed in step 2
4. ask WebKit committer Cary Clark to land the patch for me

Sound OK?
Comment 3 Adam Barth 2011-12-08 12:33:02 PST
Comment on attachment 118448 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=118448&action=review

> Source/WebKit/chromium/DEPS:35
> -  'chromium_rev': '112974',
> +  'chromium_rev': '112974', # EPOGER WILL UPDATE THIS BEFORE COMMITTING

You can use the phrase "OOPS!", which will be blocked by a pre-commit hook.
Comment 4 Adam Barth 2011-12-08 12:53:28 PST
> Sound OK?

Sounds great.
Comment 5 Tony Chang 2011-12-08 13:32:33 PST
I'll be gardening.  Let me know on IRC when you start this.
Comment 6 epoger 2011-12-09 08:18:44 PST
Committed r102454: <http://trac.webkit.org/changeset/102454>