Bug 74116 - Convert some fast/regions pixel tests to reftests
Summary: Convert some fast/regions pixel tests to reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 12:02 PST by Jacob Goldstein
Modified: 2011-12-08 17:13 PST (History)
2 users (show)

See Also:


Attachments
Patch (86.12 KB, patch)
2011-12-08 14:26 PST, Jacob Goldstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Goldstein 2011-12-08 12:02:12 PST
Convert some fast/regions pixel tests to reftests
Comment 1 Jacob Goldstein 2011-12-08 14:26:05 PST
Created attachment 118470 [details]
Patch
Comment 2 Darin Adler 2011-12-08 14:38:46 PST
Comment on attachment 118470 [details]
Patch

In the future, when changing tests to be reference tests, I would like to add explanatory text at the top of the test. Tests that have only the test content with no explanation are unnecessarily mysterious. With render tree results there is an excuse to not want extraneous content cluttering up the expected result, but with ref tests we can just repeat the explanation in both the test and the expected results.
Comment 3 WebKit Review Bot 2011-12-08 17:13:45 PST
Comment on attachment 118470 [details]
Patch

Clearing flags on attachment: 118470

Committed r102402: <http://trac.webkit.org/changeset/102402>
Comment 4 WebKit Review Bot 2011-12-08 17:13:49 PST
All reviewed patches have been landed.  Closing bug.