Bug 74104 – Web Inspector: return node counts on the document / detached root basis

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 118419 [details]
[PATCH] Proposed patch.

[WebKit Review Bot]

Attachment 118419 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10809308

[Early Warning System Bot]

Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10797302

[Collabora GTK+ EWS bot]

Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10780309

[Yury Semikhatsky]

Comment on attachment 118419 [details]
[PATCH] Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=118419&action=review

This changed should be accompanied with a test.

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:220
> +    CounterVisitor counterVisitor(domAgent, result.get());

This visitor will traverse all nodes no matter which page they belong too. We should collect only nodes relevant to a particular page which user is inspecting. You can filter them by node->document()->frame()->page() for attached documents and report all nodes from alive detached documents.

[Pavel Feldman]

Created attachment 118428 [details]
[PATCH] For ews.

[WebKit Review Bot]

Attachment 118428 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 118428 [details]
[PATCH] For ews.

Attachment 118428 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10797319

[Pavel Feldman]

Created attachment 118435 [details]
[PATCH] For ews.

[WebKit Review Bot]

Attachment 118435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 118435 [details]
[PATCH] For ews.

Attachment 118435 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10809334

[Pavel Feldman]

Created attachment 118438 [details]
[PATCH] For ews. sorry for spam.

[WebKit Review Bot]

Attachment 118438 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 118438 [details]
[PATCH] For ews. sorry for spam.

Attachment 118438 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10790342

[Pavel Feldman]

Landed as http://trac.webkit.org/changeset/102366.