Bug 74104 - Web Inspector: return node counts on the document / detached root basis
Summary: Web Inspector: return node counts on the document / detached root basis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 10:43 PST by Pavel Feldman
Modified: 2011-12-08 12:52 PST (History)
16 users (show)

See Also:


Attachments
[PATCH] Proposed patch. (10.12 KB, patch)
2011-12-08 10:45 PST, Pavel Feldman
yurys: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For ews. (10.32 KB, patch)
2011-12-08 11:12 PST, Pavel Feldman
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For ews. (10.31 KB, patch)
2011-12-08 11:47 PST, Pavel Feldman
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For ews. sorry for spam. (12.05 KB, patch)
2011-12-08 11:57 PST, Pavel Feldman
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-12-08 10:43:50 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-12-08 10:45:18 PST
Created attachment 118419 [details]
[PATCH] Proposed patch.
Comment 2 WebKit Review Bot 2011-12-08 10:50:35 PST
Attachment 118419 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2011-12-08 10:50:49 PST
Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10809308
Comment 4 Early Warning System Bot 2011-12-08 10:51:27 PST
Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10797302
Comment 5 Collabora GTK+ EWS bot 2011-12-08 10:59:53 PST
Comment on attachment 118419 [details]
[PATCH] Proposed patch.

Attachment 118419 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10780309
Comment 6 Yury Semikhatsky 2011-12-08 11:00:21 PST
Comment on attachment 118419 [details]
[PATCH] Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=118419&action=review

This changed should be accompanied with a test.

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:220
> +    CounterVisitor counterVisitor(domAgent, result.get());

This visitor will traverse all nodes no matter which page they belong too. We should collect only nodes relevant to a particular page which user is inspecting. You can filter them by node->document()->frame()->page() for attached documents and report all nodes from alive detached documents.
Comment 7 Pavel Feldman 2011-12-08 11:12:09 PST
Created attachment 118428 [details]
[PATCH] For ews.
Comment 8 WebKit Review Bot 2011-12-08 11:15:20 PST
Attachment 118428 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Early Warning System Bot 2011-12-08 11:40:43 PST
Comment on attachment 118428 [details]
[PATCH] For ews.

Attachment 118428 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10797319
Comment 10 Pavel Feldman 2011-12-08 11:47:08 PST
Created attachment 118435 [details]
[PATCH] For ews.
Comment 11 WebKit Review Bot 2011-12-08 11:49:43 PST
Attachment 118435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Early Warning System Bot 2011-12-08 11:52:16 PST
Comment on attachment 118435 [details]
[PATCH] For ews.

Attachment 118435 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10809334
Comment 13 Pavel Feldman 2011-12-08 11:57:49 PST
Created attachment 118438 [details]
[PATCH] For ews. sorry for spam.
Comment 14 WebKit Review Bot 2011-12-08 12:00:48 PST
Attachment 118438 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorMemoryAgent.cpp:50:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorMemoryAgent.h:65:  The parameter name "domAgent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Early Warning System Bot 2011-12-08 12:02:43 PST
Comment on attachment 118438 [details]
[PATCH] For ews. sorry for spam.

Attachment 118438 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10790342
Comment 16 Pavel Feldman 2011-12-08 12:51:52 PST
Landed as http://trac.webkit.org/changeset/102366.