Bug 74101 - [Qt] Update WebGraphicLayer's child content scale in all child binding method.
Summary: [Qt] Update WebGraphicLayer's child content scale in all child binding method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 09:52 PST by Jocelyn Turcotte
Modified: 2011-12-09 09:41 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.94 KB, patch)
2011-12-08 09:55 PST, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2011-12-08 10:05 PST, Jocelyn Turcotte
noam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-12-08 09:52:21 PST
[Qt] Update WebGraphicLayer's child content scale in all child binding method.
Comment 1 Jocelyn Turcotte 2011-12-08 09:55:30 PST
Created attachment 118409 [details]
Patch
Comment 2 Noam Rosenthal 2011-12-08 09:58:06 PST
Comment on attachment 118409 [details]
Patch

not sure this is needed, since e.g. GraphicsLayer::addChildBelow endds up calling setChildren
Comment 3 Jocelyn Turcotte 2011-12-08 09:59:05 PST
Comment on attachment 118409 [details]
Patch

Got to remove the modification to addChildren. If the content scale is the same this would cause notifyChange not to be called to send the parent layer update.
Comment 4 Jocelyn Turcotte 2011-12-08 10:05:00 PST
Created attachment 118413 [details]
Patch
Comment 5 Jocelyn Turcotte 2011-12-08 10:06:30 PST
(In reply to comment #2)
> (From update of attachment 118409 [details])
> not sure this is needed, since e.g. GraphicsLayer::addChildBelow endds up calling setChildren

m_children is modified, but I don't see it calling setChildren, is it straight in GraphicsLayer::addChildBelow?
Comment 6 Jocelyn Turcotte 2011-12-09 09:41:20 PST
Committed r102457: <http://trac.webkit.org/changeset/102457>