Bug 74096 - Remove EventListenerMap destructor.
Summary: Remove EventListenerMap destructor.
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-12-08 08:40 PST by Andreas Kling
Modified: 2011-12-08 10:50 PST (History)
0 users

See Also:

Patch (1.66 KB, patch)
2011-12-08 09:18 PST, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-08 08:40:52 PST
Now that the internal HashMap stores OwnPtrs it will clean up itself, so we can let the compiler generate ~EventListenerMap().
Comment 1 Andreas Kling 2011-12-08 09:18:28 PST
Created attachment 118404 [details]
Comment 2 Darin Adler 2011-12-08 10:06:22 PST
Comment on attachment 118404 [details]

I think the no iterator assert is pretty superfluous anyway. The hash map iterators already do assertions like that and our iterator is built on hash map iterators. We might want to double check that the hash map iterator checks are thorough enough and remove this extra code for EventListenerIterator.
Comment 3 Andreas Kling 2011-12-08 10:50:52 PST
Committed r102349: <http://trac.webkit.org/changeset/102349>