RESOLVED FIXED 74091
[chromium] Fix V8 bindings so Chrome will compile with ENABLE(CSS_FILTERS) 
https://bugs.webkit.org/show_bug.cgi?id=74091
Summary [chromium] Fix V8 bindings so Chrome will compile with ENABLE(CSS_FILTERS)
Stephen White
Reported 2011-12-08 07:49:18 PST
[chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS)[chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS)
Attachments
Patch (3.09 KB, patch)
2011-12-08 07:54 PST, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2011-12-08 13:01 PST, Stephen White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2011-12-08 07:54:12 PST
Created attachment 118392 [details] Patch
Kenneth Russell
Comment 2 2011-12-08 11:16:11 PST
Comment on attachment 118392 [details] Patch Looks fine. r=me
Stephen White
Comment 3 2011-12-08 11:27:00 PST
Committed r102356: <http://trac.webkit.org/changeset/102356>
Adam Barth
Comment 4 2011-12-08 12:10:00 PST
Comment on attachment 118392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review > Source/WebCore/ChangeLog:10 > + * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added. You don't need to add this file to the gypi ?
Stephen White
Comment 5 2011-12-08 12:11:43 PST
(In reply to comment #4) > (From update of attachment 118392 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review > > > Source/WebCore/ChangeLog:10 > > + * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added. > > You don't need to add this file to the gypi ? Whoops, must've reverted that change by mistake. Thanks.
Stephen White
Comment 6 2011-12-08 12:38:53 PST
Reopening to add to .gypi.
Stephen White
Comment 7 2011-12-08 13:01:36 PST
Created attachment 118456 [details] Patch
WebKit Review Bot
Comment 8 2011-12-08 16:22:25 PST
Comment on attachment 118456 [details] Patch Clearing flags on attachment: 118456 Committed r102394: <http://trac.webkit.org/changeset/102394>
WebKit Review Bot
Comment 9 2011-12-08 16:22:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.