Bug 74091 - [chromium] Fix V8 bindings so Chrome will compile with ENABLE(CSS_FILTERS)
Summary: [chromium] Fix V8 bindings so Chrome will compile with ENABLE(CSS_FILTERS)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 07:49 PST by Stephen White
Modified: 2011-12-08 16:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2011-12-08 07:54 PST, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (1.26 KB, patch)
2011-12-08 13:01 PST, Stephen White 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-12-08 07:49:18 PST 
[chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS)[chromium] Fix V8 bindings so Chrome will compile w/ENABLE(CSS_FILTERS)
Comment 1 Stephen White 2011-12-08 07:54:12 PST 
Created attachment 118392 [details]
Patch
Comment 2 Kenneth Russell 2011-12-08 11:16:11 PST 
Comment on attachment 118392 [details]
Patch

Looks fine. r=me
Comment 3 Stephen White 2011-12-08 11:27:00 PST 
Committed r102356: <http://trac.webkit.org/changeset/102356>
Comment 4 Adam Barth 2011-12-08 12:10:00 PST 
Comment on attachment 118392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review

> Source/WebCore/ChangeLog:10
> +        * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.

You don't need to add this file to the gypi ?
Comment 5 Stephen White 2011-12-08 12:11:43 PST 
(In reply to comment #4)
> (From update of attachment 118392 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118392&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
> 
> You don't need to add this file to the gypi ?

Whoops, must've reverted that change by mistake.  Thanks.
Comment 6 Stephen White 2011-12-08 12:38:53 PST 
Reopening to add to .gypi.
Comment 7 Stephen White 2011-12-08 13:01:36 PST 
Created attachment 118456 [details]
Patch
Comment 8 WebKit Review Bot 2011-12-08 16:22:25 PST 
Comment on attachment 118456 [details]
Patch

Clearing flags on attachment: 118456

Committed r102394: <http://trac.webkit.org/changeset/102394>
Comment 9 WebKit Review Bot 2011-12-08 16:22:29 PST 
All reviewed patches have been landed.  Closing bug.