Bug 74085 - Inspector: Don't translate the context when rendering the highlights on a tiled layer.
Summary: Inspector: Don't translate the context when rendering the highlights on a til...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 06:27 PST by Jocelyn Turcotte
Modified: 2011-12-12 08:54 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.16 KB, patch)
2011-12-08 07:12 PST, Jocelyn Turcotte
kenneth: review+
Details | Formatted Diff | Diff
Manual test (1.30 KB, text/html)
2011-12-12 08:54 PST, Jocelyn Turcotte
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-12-08 06:27:25 PST
Inspector: Don't translate the context when rendering the highlights on a tiled layer.
Comment 1 Jocelyn Turcotte 2011-12-08 07:12:55 PST
Created attachment 118386 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-12-09 01:50:15 PST
Comment on attachment 118386 [details]
Patch

r=me
Comment 3 Jocelyn Turcotte 2011-12-09 09:38:43 PST
Committed r102456: <http://trac.webkit.org/changeset/102456>
Comment 4 Pavel Feldman 2011-12-09 10:12:12 PST
Alexander, Joe, are you cool with these changes? I know there has been a number of incremental improvements to this code related to scrollers and iframes that you worked on.
Comment 5 Pavel Feldman 2011-12-09 10:12:46 PST
(Btw, please use webkit.org/new-inspector-bug for the inspector bug template)
Comment 6 Joseph Pecoraro 2011-12-09 12:06:17 PST
(In reply to comment #4)
> Alexander, Joe, are you cool with these changes? I know there has been a
> number of incremental improvements to this code related to scrollers and
> iframes that you worked on.

Looks good to me, Qt guys would need to know best here since "delegatesScrolling"
appears to only be used by them! That function name is not a very useful name
in this context but the comment helps clarify that.

It would also be good to attach a simple .html test case to this bugzilla bug so that
a test of this since there was no manual test or LayoutTest included in the patch.
This might fix Qt but other ports might be broken for such a case.
Comment 7 Kenneth Rohde Christiansen 2011-12-10 07:39:26 PST
delegatesScrolling basically means that webcore doesnt handle scrolling but the ui does (ie tiled backing store). If you have a better name that would be great. I guess you need something similar for iOS
Comment 8 Jocelyn Turcotte 2011-12-12 08:54:39 PST
Created attachment 118801 [details]
Manual test

Here's a manual test file, tell me if you would prefer me to push it too or if it needs adjustments.

Thanks for looking at the patch.