This bug will fix following issues with Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp a). Define DEBUG_GL_COMMANDS only for debug builds. Not sure if this change is absolutely necessary. b). Fixes a syntax error when DEBUG_GL_COMMANDS is NOT defined. Basically, this change was intended just to fix a missing semi-colon in the following block, #ifdef DEBUG_GL_COMMANDS #define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); } #else #define GL_CMD(x) x #endif To #ifdef DEBUG_GL_COMMANDS #define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); } #else #define GL_CMD(x) x; // Note the ; here #endif But, I feel convention "GL_CMD(cmd);" is better than "GL_CMD(cmd)". Hence changed the usage of macro a bit.
Created attachment 118380 [details] Patch
Comment on attachment 118380 [details] Patch Attachment 118380 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10781295
Comment on attachment 118380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118380&action=review > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:104 > -#define GL_CMD(x) {x, debugGLCommand(#x, __LINE__); } > +#define GL_CMD(x) {x, debugGLCommand(#x, __LINE__) } How would this work? Please test this fix on debug builds as well :)
Created attachment 118389 [details] Define DEBUG_GL_COMMANDS in only in release builds Sorry for my ignorance with the earlier patch. This patch just defines DEBUG_GL_COMMANDS only in release mode and adds the missing semi-colon
Comment on attachment 118389 [details] Define DEBUG_GL_COMMANDS in only in release builds Clearing flags on attachment: 118389 Committed r102359: <http://trac.webkit.org/changeset/102359>
All reviewed patches have been landed. Closing bug.