WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74081
[chromium] MediaStream API: Moving WebMediaStreamSource.h
https://bugs.webkit.org/show_bug.cgi?id=74081
Summary
[chromium] MediaStream API: Moving WebMediaStreamSource.h
Tommy Widenflycht
Reported
2011-12-08 05:38:48 PST
Moving WebMediaStreamSource.h to public/platform. Keeping a stub in public as to not affect chromium right now.
Attachments
Patch
(10.36 KB, patch)
2011-12-08 05:42 PST
,
Tommy Widenflycht
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1
2011-12-08 05:42:23 PST
Created
attachment 118372
[details]
Patch
WebKit Review Bot
Comment 2
2011-12-08 05:45:50 PST
Please wait for approval from
fishd@chromium.org
before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3
2011-12-08 11:10:39 PST
Comment on
attachment 118372
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=118372&action=review
> Source/WebKit/chromium/WebKit.gyp:325 > 'public/platform/WebMediaStreamDescriptor.h',
don't you also need to remove the old location from the gyp file?
Tommy Widenflycht
Comment 4
2011-12-09 05:05:59 PST
Comment on
attachment 118372
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=118372&action=review
>> Source/WebKit/chromium/WebKit.gyp:325 >> 'public/platform/WebMediaStreamDescriptor.h', > > don't you also need to remove the old location from the gyp file?
If you mean public/WebMediaStreamSource.h it's still there, albeit just a as forwarding stub.
Darin Fisher (:fishd, Google)
Comment 5
2011-12-09 09:38:44 PST
(In reply to
comment #4
)
> If you mean public/WebMediaStreamSource.h it's still there, albeit just a as forwarding stub.
Ah, OK! Nevermind.
WebKit Review Bot
Comment 6
2011-12-12 10:40:20 PST
Comment on
attachment 118372
[details]
Patch Clearing flags on attachment: 118372 Committed
r102603
: <
http://trac.webkit.org/changeset/102603
>
WebKit Review Bot
Comment 7
2011-12-12 10:40:24 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug