Bug 74068 – Fixing support for static conditional overloaded functions

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kaustubh Atrawalkar]

Need to fix the support for static conditional overloaded functions in JSC. For all other frameworks its working.
When overloaded functions are conditional, there are two local static functions are created. The bindings generator script pushes this "static" keyword first and then pushes "#if {conditional}" later which causes incorrect bindings being generated.

[Kaustubh Atrawalkar]

Created attachment 118350 [details]
Patch

[Adam Barth]

Comment on attachment 118350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118350&action=review

> Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp:909
> +#if ENABLE(Condition1)

It would be nice to have a blank line after this line, but that's really a minor nit.  :)

[Kaustubh Atrawalkar]

(In reply to comment #2)
> (From update of attachment 118350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118350&action=review
> 
> > Source/WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp:909
> > +#if ENABLE(Condition1)
> 
> It would be nice to have a blank line after this line, but that's really a minor nit.  :)

Thanks Adam for quick review :)

[Erik Arvidsson]

Comment on attachment 118350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118350&action=review

This does not do V8. I'm fine without V8 support in this patch. I can add it in another patch.

> Source/WebCore/bindings/scripts/test/TestObj.idl:171
> +        static [Conditional=Condition1] void overloadedMethod1(in long arg);
> +        static [Conditional=Condition1] void overloadedMethod1(in DOMString type);

Can this be called overloadedClassMethod instead?

> Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:1288
>  
> +static v8::Handle<v8::Value> overloadedMethod11Callback(const v8::Arguments& args)

This needs #if ENABLE(Condition1) too.

[WebKit Review Bot]

Comment on attachment 118350 [details]
Patch

Clearing flags on attachment: 118350

Committed r102351: <http://trac.webkit.org/changeset/102351>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.