Bug 74064 – [GTK] Change default WebSocket protocol to the latest one

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Yuta Kitamura]

[This is the GTK version of Qt's bug 73630 and I'm lazy enough to copy and paste the bug description]

Currently, WebKitGtk only supports the old WebSocket protocol (hixie-76). The old protocol is known to have a security defect, and should be phased out into the new protocol.

The new protocol (hybi-17, which is going to be published as RFC6455 soon) is already implemented in WebCore and we can switch to the new protocol using WebCore::Settings.

LayoutTests for hybi-17 are running fine on GTK bots, and there is no substantial problem observed. Hence, to migrate to the new version, we essentially just need to switch the default value of a Settings flag.

Folks, are you happy with this change? Should I bring up this topic on webkit-gtk list?

(Note: the old protocol and the new one are incompatible; if there's any existing service depending on the old protocol, it will break.)

[Martin Robinson]

Hrm. Unfortunately, this would be an API break. :( In this case it might be useful to make an exception though.

[Martin Robinson]

CCing some other people, because this situation might be one in which breaking the API is a reasonable consideration. The old default is both insecure and incompatible.

[Xan Lopez]

I think the right thing to do here is switch and add a comment in NEWS/release notes. The sooner the better.

[Gustavo Noronha (kov)]

Agreed!

[Yuta Kitamura]

Created attachment 119850 [details]
Patch

[Yuta Kitamura]

Thanks, I'm going to put the patch into CQ.

[WebKit Review Bot]

Comment on attachment 119850 [details]
Patch

Clearing flags on attachment: 119850

Committed r103321: <http://trac.webkit.org/changeset/103321>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.