Bug 74058 - [Qt] [WK2] Directly composited images don't render
Summary: [Qt] [WK2] Directly composited images don't render
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-12-07 23:11 PST by Viatcheslav Ostapenko
Modified: 2011-12-08 08:17 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2011-12-07 23:26 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-12-07 23:11:06 PST 
Load LayoutTests/compositing/direct-image-compositing.html in MiniBrowser.
All images that should be directly composited are not visible.
Comment 1 Viatcheslav Ostapenko 2011-12-07 23:25:01 PST 
Images do not attach to WebGraphicsLayer because graphics layer not yet attached to parent and layerTreeTileClient is 0.
Comment 2 Viatcheslav Ostapenko 2011-12-07 23:26:37 PST 
Created attachment 118337 [details]
Patch
Comment 3 Simon Hausmann 2011-12-08 00:43:42 PST 
Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid  putting the extra logic into syncCompositingStateForThisLayerOnly?
Comment 4 Noam Rosenthal 2011-12-08 07:34:19 PST 
(In reply to comment #3)
> Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid  putting the extra logic into syncCompositingStateForThisLayerOnly?

syncCompositingStateForThisLayerOnly is where the per-layer synchronization should occur; I'm good with adding that logic there.
Comment 5 WebKit Review Bot 2011-12-08 08:17:10 PST 
Comment on attachment 118337 [details]
Patch

Clearing flags on attachment: 118337

Committed r102342: <http://trac.webkit.org/changeset/102342>
Comment 6 WebKit Review Bot 2011-12-08 08:17:15 PST 
All reviewed patches have been landed.  Closing bug.