WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74031
fix build-webkit --chromium after breakage in
r102201
https://bugs.webkit.org/show_bug.cgi?id=74031
Summary
fix build-webkit --chromium after breakage in r102201
Dirk Pranke
Reported
2011-12-07 15:59:34 PST
fix build-webkit --chromium after breakage in
r102201
Attachments
Patch
(1.78 KB, patch)
2011-12-07 16:01 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-12-07 16:01:55 PST
Created
attachment 118285
[details]
Patch
Tony Chang
Comment 2
2011-12-07 16:02:49 PST
Comment on
attachment 118285
[details]
Patch It would be nice to add a reason for the breakage here and what the fix is.
Dirk Pranke
Comment 3
2011-12-07 16:04:50 PST
done.
Dirk Pranke
Comment 4
2011-12-07 16:12:57 PST
Committed
r102280
: <
http://trac.webkit.org/changeset/102280
>
Kentaro Hara
Comment 5
2011-12-08 05:05:12 PST
Reverted
r102280
for reason: Chromium/Windows build is broken Committed
r102332
: <
http://trac.webkit.org/changeset/102332
>
Kentaro Hara
Comment 6
2011-12-08 05:40:34 PST
(In reply to
comment #5
)
> Reverted
r102280
for reason: > > Chromium/Windows build is broken > > Committed
r102332
: <
http://trac.webkit.org/changeset/102332
>
I am sorry. I first thought that this patch caused Chromium/Windows build failure, but actually it was innocent. I cq+ed again.
WebKit Review Bot
Comment 7
2011-12-08 06:51:11 PST
Comment on
attachment 118285
[details]
Patch Clearing flags on attachment: 118285 Committed
r102335
: <
http://trac.webkit.org/changeset/102335
>
WebKit Review Bot
Comment 8
2011-12-08 06:51:16 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug