Bug 74022 - [chromium] Need to adjust memory limit and viewport multipliers.
Summary: [chromium] Need to adjust memory limit and viewport multipliers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Penner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 13:22 PST by Eric Penner
Modified: 2011-12-08 13:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2011-12-07 13:23 PST, Eric Penner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Penner 2011-12-07 13:22:31 PST
[chromium] Need to adjust memory limit and viewport multipliers.
Comment 1 Eric Penner 2011-12-07 13:23:56 PST
Created attachment 118261 [details]
Patch
Comment 2 Eric Penner 2011-12-07 13:27:30 PST
The high limit was just about to be bumped up when the original CL was submitted. This also bumps up the multipliers to match what we were are expecting at a few common viewport sizes.
Comment 3 James Robinson 2011-12-07 17:19:34 PST
Comment on attachment 118261 [details]
Patch

OK
Comment 4 WebKit Review Bot 2011-12-07 18:24:59 PST
Comment on attachment 118261 [details]
Patch

Rejecting attachment 118261 [details] from commit-queue.

New failing tests:
perf/array-reverse.html
Full output: http://queues.webkit.org/results/10781036
Comment 5 James Robinson 2011-12-07 18:26:13 PST
Comment on attachment 118261 [details]
Patch

That's a flake, trying again...
Comment 6 WebKit Review Bot 2011-12-07 21:08:39 PST
Comment on attachment 118261 [details]
Patch

Rejecting attachment 118261 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10089 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
48>At revision 10089.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10780081
Comment 7 James Robinson 2011-12-08 12:22:20 PST
Comment on attachment 118261 [details]
Patch

Goodness this patch is unlucky with the commit queue. Third time's the charm?
Comment 8 WebKit Review Bot 2011-12-08 13:05:52 PST
Comment on attachment 118261 [details]
Patch

Clearing flags on attachment: 118261

Committed r102371: <http://trac.webkit.org/changeset/102371>
Comment 9 WebKit Review Bot 2011-12-08 13:05:56 PST
All reviewed patches have been landed.  Closing bug.