Bug 74021 - Use free memory to determine if we have space for DRT instances instead of total memory
Summary: Use free memory to determine if we have space for DRT instances instead of to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 77419
  Show dependency treegraph
 
Reported: 2011-12-07 13:01 PST by Eric Seidel (no email)
Modified: 2012-01-31 10:57 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.80 KB, patch)
2011-12-07 13:02 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2011-12-07 13:17 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-12-07 13:01:52 PST
Use free memory to determine if we have space for DRT instances instead of total memory
Comment 1 Eric Seidel (no email) 2011-12-07 13:02:50 PST
Created attachment 118258 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-07 13:05:13 PST
Attachment 118258 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
 + 67d4f2d...f1b1893 master     -> origin/master  (forced update)
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 102267 = 67d4f2de4c2f4a2b6f1b3adfd20b50620fad3051
r102266 = f1b18930bbf5e73c83f2b0018b501e8f64330752
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
	M	Source/JavaScriptCore/wtf/HashTraits.h
	M	Source/JavaScriptCore/ChangeLog
	M	Source/WebCore/dom/ChildListMutationScope.cpp
	M	Source/WebCore/ChangeLog
102267 = 67d4f2de4c2f4a2b6f1b3adfd20b50620fad3051 already exists! Why are we refetching it?
 at /usr/lib/git-core/git-svn line 5210

Died at Tools/Scripts/update-webkit line 158.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2011-12-07 13:17:42 PST
Created attachment 118260 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-07 17:51:08 PST
Comment on attachment 118260 [details]
Patch

Clearing flags on attachment: 118260

Committed r102291: <http://trac.webkit.org/changeset/102291>
Comment 5 WebKit Review Bot 2011-12-07 17:51:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Seidel (no email) 2012-01-31 10:57:41 PST
This change was motivated by a private thread about the mac-bots failing NRWT on 12/2/12 involving Lucas, Dirk, rniwa, Adam Roben, Adam Barth and I.  Given the complains on bug 77419 about this method, maybe this change was folly.