Bug 74008 – add css parsing for flex-flow: wrap and wrap-reverse

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

add css parsing for flex-flow: wrap and wrap-reverse

[Tony Chang]

Created attachment 118229 [details]
Patch

[Ojan Vafai]

Comment on attachment 118229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118229&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1246
> +        m_value.ident = CSSValueNone;

Should this be CSSValueNoWrap?

[WebKit Review Bot]

Comment on attachment 118229 [details]
Patch

Attachment 118229 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10747260

New failing tests:
svg/css/getComputedStyle-basic.xhtml

[Tony Chang]

Created attachment 118267 [details]
Patch

[Tony Chang]

New version to hand the new syntax: [ row | row-reverse | column | column-reverse ] || [ nowrap | wrap | wrap-reverse ]?

[Darin Adler]

Comment on attachment 118267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118267&action=review

> Source/WebCore/css/CSSParser.cpp:1639
> +            if (value->id == CSSValueNowrap || value->id == CSSValueWrap || value->id == CSSValueWrapReverse) {
> +                list->append(cssValuePool()->createIdentifierValue(value->id));
> +                addProperty(propId, list, important);
> +                return true;
> +            }
> +            return false;

We normally use early return for the failure case. Reversing this if would make it easier to read the normal flow.

[WebKit Review Bot]

Comment on attachment 118267 [details]
Patch

Attachment 118267 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10780029

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Tony Chang]

Created attachment 118660 [details]
Patch for landing

[Ojan Vafai]

Comment on attachment 118660 [details]
Patch for landing

Clearing flags on attachment: 118660

Committed r102486: <http://trac.webkit.org/changeset/102486>

[Ojan Vafai]

All reviewed patches have been landed.  Closing bug.