Bug 74005 - [SH4] Unaligned data access in YARR_JIT
Summary: [SH4] Unaligned data access in YARR_JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 09:32 PST by thouraya
Modified: 2011-12-08 15:17 PST (History)
1 user (show)

See Also:


Attachments
patch to fix the issue (8.69 KB, patch)
2011-12-07 09:37 PST, thouraya
no flags Details | Formatted Diff | Diff
patch to fix the issue (11.31 KB, patch)
2011-12-07 09:59 PST, thouraya
barraclough: review-
Details | Formatted Diff | Diff
fix issue (11.17 KB, patch)
2011-12-08 00:18 PST, thouraya
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description thouraya 2011-12-07 09:32:06 PST
Hi,

In the function generatePatternCharacterOnce, there is a case when a word is loaded from the input string, but this data access is not aligned.

Regards,
Thouraya.
Comment 1 thouraya 2011-12-07 09:37:27 PST
Created attachment 118219 [details]
patch to fix the issue
Comment 2 WebKit Review Bot 2011-12-07 09:39:11 PST
Attachment 118219 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:174:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 thouraya 2011-12-07 09:59:01 PST
Created attachment 118224 [details]
patch to fix the issue
Comment 4 Gavin Barraclough 2011-12-07 22:01:40 PST
Comment on attachment 118224 [details]
patch to fix the issue

'WithUnalignedHalfBytes' doesn't really make a lot of sense - it's not misaligned to half a byte!
Since there is only one misalignment of a 16 bit access, I think we should name this method load16Unaligned.
Comment 5 thouraya 2011-12-08 00:18:40 PST
Created attachment 118343 [details]
fix issue
Comment 6 WebKit Review Bot 2011-12-08 15:17:10 PST
Comment on attachment 118343 [details]
fix issue

Clearing flags on attachment: 118343

Committed r102389: <http://trac.webkit.org/changeset/102389>
Comment 7 WebKit Review Bot 2011-12-08 15:17:14 PST
All reviewed patches have been landed.  Closing bug.