Bug 73992 - [filter-build-webkit] should not emit reset color when --no-color is given
Summary: [filter-build-webkit] should not emit reset color when --no-color is given
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 02:47 PST by Hajime Morrita
Modified: 2011-12-21 20:08 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2011-12-07 02:53 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-12-07 02:47:11 PST
filter-build-webkit writes reset color control code even when it --no-color is given.
I hope not to emit this because my Emacs cannot handle it well...
Comment 1 Hajime Morrita 2011-12-07 02:53:10 PST
Created attachment 118195 [details]
Patch
Comment 2 Hajime Morrita 2011-12-07 02:55:57 PST
Hi guys, could you take a look at this small change?
Comment 3 Daniel Bates 2011-12-07 06:32:56 PST
Comment on attachment 118195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review

OK

> Tools/ChangeLog:7
> +

You should briefly explain the purpose of this fix and how youR environment is affected without this fix.
Comment 4 Hajime Morrita 2011-12-07 17:57:20 PST
(In reply to comment #3)
> (From update of attachment 118195 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review
> 
> OK
> 
> > Tools/ChangeLog:7
> > +
> 
> You should briefly explain the purpose of this fix and how youR environment is affected without this fix.

Thanks! I'll add an explanation before landing.
Comment 5 Hajime Morrita 2011-12-21 20:07:59 PST
Comment on attachment 118195 [details]
Patch

Landed by hand. closing and clearing flags.
http://trac.webkit.org/changeset/102296