RESOLVED FIXED 73992
[filter-build-webkit] should not emit reset color when --no-color is given 
https://bugs.webkit.org/show_bug.cgi?id=73992
Summary [filter-build-webkit] should not emit reset color when --no-color is given
Hajime Morrita
Reported 2011-12-07 02:47:11 PST
filter-build-webkit writes reset color control code even when it --no-color is given. I hope not to emit this because my Emacs cannot handle it well...
Attachments
Patch (1.66 KB, patch)
2011-12-07 02:53 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-12-07 02:53:10 PST
Created attachment 118195 [details] Patch
Hajime Morrita
Comment 2 2011-12-07 02:55:57 PST
Hi guys, could you take a look at this small change?
Daniel Bates
Comment 3 2011-12-07 06:32:56 PST
Comment on attachment 118195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review OK > Tools/ChangeLog:7 > + You should briefly explain the purpose of this fix and how youR environment is affected without this fix.
Hajime Morrita
Comment 4 2011-12-07 17:57:20 PST
(In reply to comment #3) > (From update of attachment 118195 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118195&action=review > > OK > > > Tools/ChangeLog:7 > > + > > You should briefly explain the purpose of this fix and how youR environment is affected without this fix. Thanks! I'll add an explanation before landing.
Hajime Morrita
Comment 5 2011-12-21 20:07:59 PST
Comment on attachment 118195 [details] Patch Landed by hand. closing and clearing flags. http://trac.webkit.org/changeset/102296
Note You need to log in before you can comment on or make changes to this bug.