RESOLVED FIXED 73986
change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline 
https://bugs.webkit.org/show_bug.cgi?id=73986
Summary change function name InitializeLoggingChannelsIfNecessary to follow coding st...
Mary Wu
Reported 2011-12-07 00:04:08 PST
According to WebKit coding style guideline "Lower-case the first letter, including all letters in an acronym, in a variable or function name", but the function name InitializeLoggingChannelsIfNecessary in the file WebCore/platform/Logging.h break the rule. We need to change the name to initializeLoggingChannelsIfNecessary in the header file and all its porting implementations.
Attachments
Patch (14.92 KB, patch)
2011-12-07 00:08 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (15.60 KB, patch)
2011-12-07 00:16 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2011-12-07 00:08:21 PST
Created attachment 118176 [details] Patch
Mary Wu
Comment 2 2011-12-07 00:16:35 PST
Created attachment 118177 [details] Patch
Leo Yang
Comment 3 2011-12-07 02:19:36 PST
LGTM.
WebKit Review Bot
Comment 4 2011-12-07 06:54:29 PST
Comment on attachment 118177 [details] Patch Clearing flags on attachment: 118177 Committed r102235: <http://trac.webkit.org/changeset/102235>
WebKit Review Bot
Comment 5 2011-12-07 06:54:34 PST
All reviewed patches have been landed. Closing bug.
Jessie Berlin
Comment 6 2011-12-07 08:15:12 PST
FYI, this change broke the Mac build because you did not update the name in the WebCore.exp.in file. Fixed in http://trac.webkit.org/changeset/102241
Mary Wu
Comment 7 2011-12-07 18:18:56 PST
thanks for the fix, Jessie
Note You need to log in before you can comment on or make changes to this bug.