Bug 73973 – Add beforeprint and afterprint events

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Printing

[Ben Wells]

Add beforeprint and afterprint events

[Ben Wells]

Created attachment 118161 [details]
WIP

[Ben Wells]

Comment on attachment 118161 [details]
WIP

Need to do more analysis of IE and FF behaviour, and need to add tests.

[Adam Barth]

Comment on attachment 118161 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=118161&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

No tests, partner?  Lots of stuff in this patch is easy to test.

[Adam Barth]

> Need to do more analysis of IE and FF behaviour, and need to add tests.

Ah, sorry!  I thought you nominated this patch for review.

[Ojan Vafai]

This can wait till you've done the IE/FF analysis, but before getting this reviewed you'll need to send an email to webkit-dev: http://www.webkit.org/coding/adding-features.html.

[Sam Weinig]

(In reply to comment #5)
> This can wait till you've done the IE/FF analysis, but before getting this reviewed you'll need to send an email to webkit-dev: http://www.webkit.org/coding/adding-features.html.

Due to the fact that is such a small enhancement (and other browsers implement it) I don't really see a need for discussion on webkit-dev.

[Alexey Proskuryakov]

This bug has some discussion, but probably not as much to reverse dupe. Marking duplicate of the older one.

I agree that this doesn't sound like a feature that needs #ifdefs or requires webkit-dev e-mail.

*** This bug has been marked as a duplicate of bug 19937 ***

[Alexey Proskuryakov]

Looking at the patch, it appears that beforeprint will be only dispatched after switching to printing mode. That seems suspicious.