Bug 73973 - Add beforeprint and afterprint events
Summary: Add beforeprint and afterprint events
Status: RESOLVED DUPLICATE of bug 19937
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Wells
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-06 19:05 PST by Ben Wells
Modified: 2011-12-07 14:08 PST (History)
6 users (show)

See Also:

Attachments
WIP (7.68 KB, patch)
2011-12-06 19:18 PST, Ben Wells 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Wells 2011-12-06 19:05:33 PST 
Add beforeprint and afterprint events
Comment 1 Ben Wells 2011-12-06 19:18:22 PST 
Created attachment 118161 [details]
WIP
Comment 2 Ben Wells 2011-12-06 19:21:22 PST 
Comment on attachment 118161 [details]
WIP

Need to do more analysis of IE and FF behaviour, and need to add tests.
Comment 3 Adam Barth 2011-12-06 19:51:34 PST 
Comment on attachment 118161 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=118161&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

No tests, partner?  Lots of stuff in this patch is easy to test.
Comment 4 Adam Barth 2011-12-06 19:51:59 PST 
> Need to do more analysis of IE and FF behaviour, and need to add tests.

Ah, sorry!  I thought you nominated this patch for review.
Comment 5 Ojan Vafai 2011-12-07 10:38:14 PST 
This can wait till you've done the IE/FF analysis, but before getting this reviewed you'll need to send an email to webkit-dev: http://www.webkit.org/coding/adding-features.html.
Comment 6 Sam Weinig 2011-12-07 12:08:50 PST 
(In reply to comment #5)
> This can wait till you've done the IE/FF analysis, but before getting this reviewed you'll need to send an email to webkit-dev: http://www.webkit.org/coding/adding-features.html.

Due to the fact that is such a small enhancement (and other browsers implement it) I don't really see a need for discussion on webkit-dev.
Comment 7 Alexey Proskuryakov 2011-12-07 13:50:46 PST 
This bug has some discussion, but probably not as much to reverse dupe. Marking duplicate of the older one.

I agree that this doesn't sound like a feature that needs #ifdefs or requires webkit-dev e-mail.

*** This bug has been marked as a duplicate of bug 19937 ***
Comment 8 Alexey Proskuryakov 2011-12-07 14:08:42 PST 
Looking at the patch, it appears that beforeprint will be only dispatched after switching to printing mode. That seems suspicious.