Bug 73958 - [chromium] Clearing root surface should happen after damage tracking
Summary: [chromium] Clearing root surface should happen after damage tracking
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
Depends on:
Reported: 2011-12-06 15:52 PST by Shawn Singh
Modified: 2011-12-07 18:02 PST (History)
5 users (show)

See Also:

Patch (5.04 KB, patch)
2011-12-06 15:57 PST, Shawn Singh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2011-12-06 15:52:47 PST
There was a minor bug in the scissoring optimization that the root surface clear was happening before the scissor was actually computed.  I went ahead cleaned up that code at the same time.  No obvious regressions on layout tests on OSX, works fine with manual testing.

Jonathan, can you please verify that this patch fixes the partial swap problem on your side before we flag it for official review?  (Don't forget to manually remove the usingPartialSwap=false, otherwise it will seem to work without actually doing partial swap) Thanks in advance!
Comment 1 Shawn Singh 2011-12-06 15:57:50 PST
Created attachment 118128 [details]
Comment 2 Jonathan Backer 2011-12-07 07:37:54 PST
Fixes the problems that I was having with OSX 10.6
Comment 3 James Robinson 2011-12-07 17:43:52 PST
Comment on attachment 118128 [details]

Comment 4 WebKit Review Bot 2011-12-07 18:02:31 PST
Comment on attachment 118128 [details]

Clearing flags on attachment: 118128

Committed r102294: <http://trac.webkit.org/changeset/102294>
Comment 5 WebKit Review Bot 2011-12-07 18:02:37 PST
All reviewed patches have been landed.  Closing bug.